Update to use adafruit_pixelbuf. #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
code looks good to me. I'm working on testing this with a Trinket M0, it will take me a minute to get the proper builds of CP ready. I'll make a followup post here once testing is complete. |
FoamyGuy
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
I realized after my previous comment that Trinket M0 is not the best to test this with because it uses pypixelbuf instead of the module built-in to the core.
I tested this successfully with an ItsyBitsy M0 using the simpletest script from this repo. Confirmed that it runs successfully on 6.3.0, 7.0.0-alpha.4 and the build artifact from PR #5010
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 4.4.0 from 4.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#106 from kattni/keypad-gamepad > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.1.0 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#56 from kattni/pixelbuf-update > Moved default branch to main > Moved CI to Python 3.7 Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.2.0 from 6.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#115 from kattni/pixelbuf-update > Moved default branch to main > Moved CI to Python 3.7 Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.2.0 from 2.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#63 from jerryneedell/jerryn_crc > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#63 from makermelissa/main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adafruit/circuitpython#5010 renames
_pixelbuftoadafruit_pixelbuf.Maintains backwards compatibility until such time that we are ready to remove it.