Rename _pixelbuf to adafruit_pixelbuf, alias. #5010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The updates to NeoPixel and DotStar are incoming. |
This was referenced Jul 16, 2021
dhalbert
requested changes
Jul 16, 2021
| @@ -177,7 +177,7 @@ const mp_obj_property_t pixelbuf_pixelbuf_bpp_obj = { | |||
| //| before they are adjusted for brightness.""" | |||
| //| | |||
| STATIC mp_obj_t pixelbuf_pixelbuf_obj_get_brightness(mp_obj_t self_in) { | |||
| return mp_obj_new_float(common_hal__pixelbuf_pixelbuf_get_brightness(self_in)); | |||
| return mp_obj_new_float(common_hal__adafruit_pixelbuf_pixelbuf_get_brightness(self_in)); | |||
There was a problem hiding this comment.
Suggested change
| return mp_obj_new_float(common_hal__adafruit_pixelbuf_pixelbuf_get_brightness(self_in)); | |
| return mp_obj_new_float(common_hal_adafruit_pixelbuf_pixelbuf_get_brightness(self_in)); |
|
Build failures are due to xtensa build caching. Nothing to do with your changes. To fix, we need to change the cache key: NEW In general, we update the key to today's date. It is not clear to me at all why and when this happens, but this kind of thing is the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_pixelbuftoadafruit_pixelbuf._pixelbuftoadafruit_pixelbuffor backwards compatibility.