-
Notifications
You must be signed in to change notification settings - Fork 60
stability improvements #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run |
__version__ = "0.0.0-auto.0" | ||
__version__ = "3.6.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason this was done? I think we should have it set to the current version in github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason - accident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries, just change it back after you run black. Thanks!
@fvzeppelin Otherwise, seems good. I don't see any potential for any breakages arising from this, and I have tested it on the MTK3339, so I'll merge this when it's passing the CI |
@dherrada now, checks have passed :) But I could not test it on the target, yet. |
@fvzeppelin No worries, black won't change anything functional. One more thing, change the version back to 3.6.3 and I can merge. edit: That is, unless you haven't tested the first version of this PR on the NEO-7M. In that case, we can wait until you do that. |
@dherrada I had tested the version before applying black with a NEO-7M and an ItsyBitsy M0 Express. |
awesome. Merging |
Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.6.4 from 3.6.3: > Revert version to right version > Merge pull request adafruit/Adafruit_CircuitPython_GPS#47 from fvzeppelin/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#9 from kattni/update-rtd > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#8 from kattni/example-name-update Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.2.1 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#14 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#13 from adafruit/setup-py-disabled > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#13 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#12 from adafruit/setup-py-disabled > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#19 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#18 from adafruit/setup-py-disabled > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.4.0 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#18 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#17 from adafruit/setup-py-disabled > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_SHTC3, Adafruit_CircuitPython_SSD1351, Adafruit_CircuitPython_ST7735, Adafruit_CircuitPython_ST7735R, Adafruit_CircuitPython_ST7789
my NEO-7M likes to send this, so I need to catch it ;)