Skip to content

stability improvements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2020
Merged

stability improvements #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed11af0
fixes
Jun 1, 2020
10a4a02
black'ed
Jun 8, 2020
6f4cd1c
change version to 3.6.3
Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions adafruit_gps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
import time
from micropython import const

__version__ = "0.0.0-auto.0"
__version__ = "3.6.3"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason this was done? I think we should have it set to the current version in github.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason - accident

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, just change it back after you run black. Thanks!

__repo__ = "https://github.com/adafruit/Adafruit_CircuitPython_GPS.git"


Expand Down Expand Up @@ -260,7 +260,7 @@ def _parse_sentence(self):

def _parse_gpgll(self, args):
data = args.split(",")
if data is None or data[0] is None:
if data is None or data[0] is None or (data[0] == ""):
return # Unexpected number of params.

# Parse latitude and longitude.
Expand Down Expand Up @@ -295,7 +295,7 @@ def _parse_gprmc(self, args):
# Parse the arguments (everything after data type) for NMEA GPRMC
# minimum location fix sentence.
data = args.split(",")
if data is None or len(data) < 11 or data[0] is None:
if data is None or len(data) < 11 or data[0] is None or (data[0] == ""):
return # Unexpected number of params.
# Parse fix time.
time_utc = int(_parse_float(data[0]))
Expand Down Expand Up @@ -374,7 +374,7 @@ def _parse_gpgga(self, args):
# Parse the arguments (everything after data type) for NMEA GPGGA
# 3D location fix sentence.
data = args.split(",")
if data is None or len(data) != 14:
if data is None or len(data) != 14 or (data[0] == ""):
return # Unexpected number of params.
# Parse fix time.
time_utc = int(_parse_float(data[0]))
Expand Down Expand Up @@ -421,7 +421,7 @@ def _parse_gpgga(self, args):

def _parse_gpgsa(self, args):
data = args.split(",")
if data is None:
if data is None or (data[0] == ""):
return # Unexpected number of params

# Parse selection mode
Expand All @@ -444,7 +444,7 @@ def _parse_gpgsv(self, args):
# Parse the arguments (everything after data type) for NMEA GPGGA
# 3D location fix sentence.
data = args.split(",")
if data is None:
if data is None or (data[0] == ""):
return # Unexpected number of params.

# Parse number of messages
Expand Down