Skip to content

doc(mypy): Add type annotations to function definitions #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2021
Merged

doc(mypy): Add type annotations to function definitions #86

merged 3 commits into from
Oct 17, 2021

Conversation

careyk007
Copy link
Contributor

I have added the missing type annotations identified by the command mypy --disallow-untyped-defs --disallow-incomplete-defs --ignore-missing-imports adafruit_hid

Closes #83

dhalbert
dhalbert requested changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've generalized what some args can take (which was always true).

@careyk007
Copy link
Contributor Author

@dhalbert Thanks for the review! There is an issue with the documentation build step of the workflow that I am trying to resolve.

dhalbert
dhalbert approved these changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit a093229 into adafruit:main Oct 17, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 20, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b81efd7)
90ed296 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.2.0 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#11 from rhooper/led_animation_compat
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#12 from jsymons/change_default

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.2 from 1.10.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#87 from kattni/tweaks

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.1.2 from 5.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#86 from careyk007/add_missing_type_annotations
  > Globally disabled consider-using-f-string pylint check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@careyk007 @dhalbert