Change default #12
Merged
Change default #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaintYourDragon
approved these changes
Oct 15, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.2.0 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#11 from rhooper/led_animation_compat > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#12 from jsymons/change_default Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.2 from 1.10.1: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#87 from kattni/tweaks Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 5.1.2 from 5.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_HID#86 from careyk007/add_missing_type_annotations > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
Nonefor thecolorparameter inIS31FL3741_colorXY.fillwould cause errors if they were actually used as per discussion in #8This PR changes that default the value to 0 instead, which should accomplish what I'm assuming the original intent of the
Nonedefault was: turning off the pixels.