Skip to content

Add INTCAP register access #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021

Conversation

flyte
Copy link
Contributor

@flyte flyte commented Jan 26, 2021

Add access to INTCAP registers in order to read the value of a pin at the point of interrupt.

@jposada202020 jposada202020 requested a review from a team May 13, 2021 22:10
@jposada202020 jposada202020 added the enhancement New feature or request label May 13, 2021
@jposada202020
Copy link
Contributor

@flyte I will have hardware to test this week, however I do have a question. I just need to call the property after library instantiation?

@jposada202020 jposada202020 self-assigned this May 17, 2021
@flyte
Copy link
Contributor Author

flyte commented May 17, 2021

Yep, I think so. It's not exactly fresh in my mind any more though 😅

@jposada202020
Copy link
Contributor

first of all I am sorry, but cmon is has been only 4 months 😄 . But I promise that I will test this week for sure ... If I remember .. 🤦🏼 😄 . now for real, hopefully hardware will be here by Thursday and I can test. Thanks again

Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was tested on

Adafruit CircuitPython 7.0.0-alpha.2-608-gd134e2af8 on 2021-05-19; Adafruit Feather M4 CAN with same51j19a

using the following simplified test code

>>> import board
>>> import digitalio
>>> from adafruit_mcp230xx.mcp23017 import MCP23017
>>> i2c = board.I2C()
>>> mcp = MCP23017(i2c)
>>> mcp.
iodir           gppu            iocon           _write_u16le
gpio            _read_u16le     gpioa           _read_u8
_write_u8       gpiob           iodira          iodirb
gppua           gppub           get_pin         ipol
ipola           ipolb           interrupt_configuration
interrupt_enable                default_value   io_control
int_flag        int_flaga       int_flagb       int_cap
int_capa        int_capb        clear_ints      clear_inta
clear_intb
>>> mcp.int_cap
[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
>>> mcp.int_capa
[0, 0, 0, 0, 0, 0, 0, 0]
>>> mcp.int_capb
[0, 0, 0, 0, 0, 0, 0, 0]

Works as described. Thanks

@jposada202020 jposada202020 merged commit 3267a47 into adafruit:master May 19, 2021
@jposada202020
Copy link
Contributor

Thanks sorry for the delay...

@flyte
Copy link
Contributor Author

flyte commented May 20, 2021

No worries! I didn't mean that you'd taken too long, just that my memory is terrible!

@jposada202020
Copy link
Contributor

:) it is all good. Thanks again 👍🏼

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 22, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.8 from 1.2.7:
  > Added help text and problem matcher
  > Linting
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.4 from 2.6.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#51 from jposada202020/adding_example_pico_API
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.0.4 from 2.0.3:
  > Added help text and problem matcher
  > Linted
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.8 from 1.3.7:
  > Added help text and problem matcher
  > Linted
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.1.6 from 1.1.5:
  > Added help text and problem matcher
  > Making actions pass
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.1.5 from 1.1.4:
  > Added help text and problem matcher
  > Trying to make actions pass
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.6 from 2.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#38 from flyte/feature/mcp23017-intcap
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#40 from FoamyGuy/pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.7 from 3.3.6:
  > Added help text and problem matcher
  > Added pull request template
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#29 from jposada202020/adding_functions

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.7 from 1.2.6:
  > Added help text and problem matcher
  > Linted
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.6 from 1.1.5:
  > Added help text and problem matcher
  > Linted
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.1 from 1.0.0:
  > Added help text and problem matcher
  > Linted
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.3 from 1.0.2:
  > Added help text and problem matcher
  > Linted
  > Added pull request template
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#4 from FoamyGuy/pylint_to_precommit

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 2.2.3 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#43 from jposada202020/correcting_readthedocs_API
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants