-
Notifications
You must be signed in to change notification settings - Fork 17
adding methods to setup critical/upper and lower temperatures #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these! One suggestion about the comments.
Will do, just wanted to know if still wanted, I need to correct all the docs, change the number type to const(0x03), defining those in Library_variable, approach a little more to the Library standars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more things. Thanks!
@tannewt before you take a long journey in the BLE stuff could you verify this... :) thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more things. Thanks for improving this!
@tannewt changes were done as suggested. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more minor things. Thanks!
Co-authored-by: Scott Shawcroft <[email protected]>
Co-authored-by: Scott Shawcroft <[email protected]>
Co-authored-by: Scott Shawcroft <[email protected]>
Co-authored-by: Scott Shawcroft <[email protected]>
Co-authored-by: Scott Shawcroft <[email protected]>
Co-authored-by: Scott Shawcroft <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you!
Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.8 from 1.2.7: > Added help text and problem matcher > Linting > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.4 from 2.6.3: > Merge pull request adafruit/Adafruit_CircuitPython_BME280#51 from jposada202020/adding_example_pico_API > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.0.4 from 2.0.3: > Added help text and problem matcher > Linted > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.8 from 1.3.7: > Added help text and problem matcher > Linted > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.1.6 from 1.1.5: > Added help text and problem matcher > Making actions pass > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.1.5 from 1.1.4: > Added help text and problem matcher > Trying to make actions pass > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.4.6 from 2.4.5: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#38 from flyte/feature/mcp23017-intcap > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold " > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#40 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.7 from 3.3.6: > Added help text and problem matcher > Added pull request template > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#29 from jposada202020/adding_functions Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.7 from 1.2.6: > Added help text and problem matcher > Linted > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.6 from 1.1.5: > Added help text and problem matcher > Linted > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.1 from 1.0.0: > Added help text and problem matcher > Linted > Added pull request template > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1681 to 1.0.3 from 1.0.2: > Added help text and problem matcher > Linted > Added pull request template > "Increase duplicate code check threshold " > Merge pull request adafruit/Adafruit_CircuitPython_SSD1681#4 from FoamyGuy/pylint_to_precommit Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 2.2.3 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#43 from jposada202020/correcting_readthedocs_API > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold "
Solves #27.
Trying to implement different functions according to issue 27. If this is already included after the board revision please feel free to close this PR. I could implement the other functions, just want to verify first.
Tested in
This could be tested using the following script