Fix timing issue #20
Fix timing issue #20
Conversation
This line of code as written creates a TIH timing of 625ns, which is short of the 800ns recommended. Some neopixels will not work with this timing. An example of the problem and the solution (as identified and solved by Twitter user @bornach) can be found in this Twitter thread (https://twitter.com/Bornach1/status/1301087477034344449?s=20)
|
What specific product are you using? There are variations in the timing specifications among various "neopixel" like products. The current timings were tweaked to work with SK6812. @ladyada Do we want to support other timings? WS2811 (400kHz) WS2812 WS2812B SK6812 |
|
I'm using a version of these: https://www.adafruit.com/product/1938, though mine aren't sourced from Adafruit. I'd be curious to know if the ones you sell work with the library as written or not. |
|
The current library timings appear to work OK with PID 1938 NeoPixels. $ python3
Python 3.6.9 (default, Jul 17 2020, 12:50:27)
[GCC 8.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import board
>>> import neopixel_spi as neopixel
>>> pixels = neopixel.NeoPixel_SPI(board.SPI(), 1, pixel_order=neopixel.RGB)
>>> pixels.fill(0xADAF00)
>>>
|
|
@geekmomprojects Do you know how to test PR code? If so, checkout the proposed changes I've submitted in #21 |
Yes, I should be able to test your changes. I will check it out and respond in a bit. Thank you! |
Tested successfully. Thank you. The PR code works well - and is a nice, flexible fix for the timing issue. |
|
Closing this in favor of #22 |
This line of code as written creates a T1H timing of 625ns, which is short of the 800ns recommended. Some neopixels will not work with this timing. An example of the problem and the solution (as identified and solved by Twitter user @bornach) can be found in this Twitter thread (https://twitter.com/Bornach1/status/1301087477034344449?s=20)