Make things tunable via kwargs #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #19 and as another option to #20 and #21. This approach uses kwargs instead of properties.
This will allow for "tuning" of the underlying timings for better support of other flavor addressable RGBs. There are four parameters (new kwargs) that are involved:
frequency
- The SPI bus frequency, really only two values that matter. Added as an init parameter.reset_time
- The reset time value (TRST). Added as a new property.bit0
- The byte that defines timing for a 0 bit (T0H+T0L). Added as a new property.bit1
-The byte that defines timing for a 1 bit (T1H+T1L). Added as a new property.This example shows tweaking the bit 1 pattern which may work for the case discussed in #19 and #20: