Skip to content

Remove ntp client #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Remove ntp client #123

merged 2 commits into from
Jul 21, 2023

Conversation

BiffoBear
Copy link
Contributor

Closes #114
Closes #118
@dhalbert @kattni @Neradoc
Removed the Wiznet5k NTP client module by deleting the file. Built the docs with Sphinx, references to the NTP client do not appear in the docs.
The NTP client is not accessed in any of the example files.
N.B. I had to modify the Sphinx conf.py file to build the docs (Thx Kattni 😀). That change was reverted before pushing to GitHub.

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with this change!

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @BiffoBear!

@FoamyGuy FoamyGuy merged commit a973ed2 into adafruit:main Jul 21, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 22, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#130 from fasteddy516/fix_socket_swap
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#123 from BiffoBear/remove_ntp_client
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#122 from BiffoBear/fix_socket_leaks

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 2.0.1 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#136 from DJDevon3/WorkingBranch

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTP Out of Sockets Error NTP client not working with chrony
3 participants