Fix socket swap in socket.accept() #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Looks good to me. Thank you @fasteddy516
I tested it successfully with a Feather S3 TFT + Ethernet Featherwing (Wiznet5k 5500) using the linked visualizer (neat project, thanks for sharing!) as well as simpletest, cheerlights, and simpleserver examples from inside this repo.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 22, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 5.0.1 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#130 from fasteddy516/fix_socket_swap > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#123 from BiffoBear/remove_ntp_client > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#122 from BiffoBear/fix_socket_leaks Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 2.0.1 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#136 from DJDevon3/WorkingBranch Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129. Prevents listening for connections on hardware socket 0 and marking unused sockets as reserved when
socket.accept()is called and hardware socket 0 is available.Tested with CircuitPython 8.2.0-rc.1 on a Raspberry Pi Pico with WIZnet Ethernet Hat (w5100s chipset) using my CircuitPython WIZnet5k Socket Visualizer.