Skip to content

Update Tinyusb #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 23, 2019
Merged

Update Tinyusb #2379

merged 8 commits into from
Dec 23, 2019

Conversation

hierophect
Copy link
Collaborator

This PR updates to the latest version of TinyUSB to access manual VBUS enabling for STM32 microcontrollers. Currently, it compiles on all ports but NRF, which has some renamed structures.

I'd appreciate any help in testing across ports and boards since I don't currently have most of them on hand! Edits of any kind are welcome.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nrf build break since it requires nrfx update to version 2.x to support new mcu nrf52833 and nrf5340. @dhalbert is there any issue upgrading nrfx to v2, I can help to do that as well.

@dhalbert
Copy link
Collaborator

@hathach There is probably not an issue upgrading to nrfx 2.x, but I already made changes to 1.x which will need to be merged (make uninit() routines be callable more than once: adafruit/nrfx#1).

@hathach
Copy link
Member

hathach commented Dec 13, 2019

@hathach There is probably not an issue upgrading to nrfx 2.x, but I already made changes to 1.x which will need to be merged (make uninit() routines be callable more than once: adafruit/nrfx#1).

Got it, I will help to submit PR to update our nrfx folk to v2 & cpython. It has an API changes to require even single module e.g NRF_USBD must be passed to driver function as well.

@hathach
Copy link
Member

hathach commented Dec 17, 2019

@hierophect I made a PR to your branch to fix warnings https://github.com/hierophect/circuitpython/pull/1

I am upgrading nrfx for circuitpython to v2.0 (will submit a separate PR), once this is done, the travis build should pass, and we will also be able to add support for nrf52833 and nrf5340.

@hathach
Copy link
Member

hathach commented Dec 17, 2019

once this PR get merged #2395 we could fetch from that, and hopefully the travis build could be fixed.

stm32 explicitily enable/disable vbus sense, fix warning
@hierophect
Copy link
Collaborator Author

@hathach thanks for the PR, I didn't have the explicit disable which might have caused problems down the line.

@hierophect hierophect mentioned this pull request Dec 17, 2019
4 tasks
@hathach
Copy link
Member

hathach commented Dec 18, 2019

@hierophect I submit another PR to sync with master tips, though since the master is very actively developed, there is quite a bit of chances. But I think it is safe to merge, you may want to double check and/or review the changes yourself https://github.com/hierophect/circuitpython/pull/2 . Hopefully once it is merged this PR is ready as well.

merge with current master of circuitpython
@hathach hathach marked this pull request as ready for review December 19, 2019 06:11
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for maybe rename BOARD_NO_VBUS to BOARD_NO_VBUS_SENSE, I think this PR is ready to merge. @hierophect do you want to make any other changes for the PR ?

@hathach
Copy link
Member

hathach commented Dec 23, 2019

Merged to fix issue #2421 we could rename things later on if needed.

@jerryneedell
Copy link
Collaborator

Works on feather_stm32f405 connected to a Linux system! Thanks!

@hierophect
Copy link
Collaborator Author

@hathach thanks for picking up the slack on this while I was traveling, sorry I wasn't able to update promptly. I'll get a PR in for the text fix today.

@hierophect
Copy link
Collaborator Author

@hathach I'm getting git bugs with tinyusb when I use git submodule update --init --recursive now:
fatal: not a git repository: hw/mcu/nxp/../../../../../.git/modules/lib/tinyusb/modules/hw/mcu/nxp

Happens even after a fresh clone. Something to look into?

@hierophect hierophect deleted the update-tusb branch December 23, 2019 19:57
@hathach
Copy link
Member

hathach commented Dec 24, 2019

@hierophect no problems at all, I am not in hurry If not for fixing the urgent bug with feather stm32f405. Regarding the submodule, I am not so sure why even a fresh clone didn't work hmmmm. Please try to follow Scott suggestion hathach/tinyusb#242 to see if that works. Scott is git master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants