adjust stack for SAMD21 to accommodate larger pystack #3213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n module adafruit_busdevice
dhalbert
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase pystack by 512 bytes
decrease SAMD21 stack by 512 bytes
fixes #3208 - this was the original impetus for the update since pystack was too small to use the airlift.
also update frozen module Adafruit_CircuitPython_BusDevice -- not sure if I did this correctly but it works...
Tested on CircuitPlayGround Express -- able to import express library
from adafruit_circuitplayground.express import cpx
Are there other tests that need to be done with he crickit or displayio variants?
also tested on metro_m4_airlift_lite to verify #3208 fixed.
Only the pystack size in py/circuitpy_mpconfigport.h and the specific setting of CIRCUITPY_DEFAULT_STACK_SIZE for the atmel-samd SAMD21 are changed since it is the most impacted. It did not seem necessary to change all the other ports with stacks sized 20K or greater for the 512 byte difference. They can be added if desired.
also verified that several SAMD21 build seem to work normally
trinket_m0,pyruler_gemma_m0,pewpew10
the only issue I am having is with irremote(pulseio) and taht appears to be a 6.0.0-alpha2 issue in general -- see #3216