-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Switch our workflows to ubuntu 20.04 #3705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The lone failure was a network glitch. However, as this PR's home branch is not adafruit/circuitpython, it doesn't actually test s3 uploads which @dhalbert mentioned as a potential incompatibility. |
I looked over the Looks like we should set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These steps use ubuntu-latest
instead of an explicit version, so maybe we should change them to ubuntu-20.04
. That way they won't change out from under us in two years.
workflows/create_website_pr.yml
13: runs-on: ubuntu-latest
workflows/build.yml
418: runs-on: ubuntu-latest
workflows/pre-commit.yml
14: runs-on: ubuntu-latest
a87d071
to
a0d3050
Compare
I had a mistaken commit in there (disabling ulab on some stm boards) so I rebased it out and force-pushed. |
I just remembered this: #3629 (review)
|
I pushed it to an adafruit branch as well, run results will be at https://github.com/adafruit/circuitpython/actions/runs/368709935 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uploads in adafruit branch build look fine! Thanks for doing this!
@dhalbert excellent. Looks like you have to re-review since I had entered this in draft state |
I think it's not green just because of the one failing build (which is just network trouble). |
This switches some which were using ubuntu-latest and some which were using ubuntu-16.04, all to 20.04. When 22.04 is added on GH Actions we can revisit this.