Skip to content

Switch our workflows to ubuntu 20.04 #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Conversation

jepler
Copy link

@jepler jepler commented Nov 16, 2020

This switches some which were using ubuntu-latest and some which were using ubuntu-16.04, all to 20.04. When 22.04 is added on GH Actions we can revisit this.

@jepler
Copy link
Author

jepler commented Nov 17, 2020

The lone failure was a network glitch. However, as this PR's home branch is not adafruit/circuitpython, it doesn't actually test s3 uploads which @dhalbert mentioned as a potential incompatibility.

@jepler jepler requested a review from dhalbert November 17, 2020 02:39
@dhalbert
Copy link
Collaborator

I looked over the aws changes, and I just see this as a possible issue:
https://docs.aws.amazon.com/cli/latest/userguide/cliv2-migration.html#cliv2-migration-output-pager

Looks like we should set AWS_PAGER to nothing to avoid having it hang waiting for paging. (I'm surprised that a pager might not notice it's being run in a script and do nothing.)

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These steps use ubuntu-latest instead of an explicit version, so maybe we should change them to ubuntu-20.04. That way they won't change out from under us in two years.

workflows/create_website_pr.yml
13:    runs-on: ubuntu-latest

workflows/build.yml
418:    runs-on: ubuntu-latest

workflows/pre-commit.yml
14:    runs-on: ubuntu-latest

@jepler
Copy link
Author

jepler commented Nov 17, 2020

I had a mistaken commit in there (disabling ulab on some stm boards) so I rebased it out and force-pushed.

@dhalbert
Copy link
Collaborator

dhalbert commented Nov 17, 2020

I just remembered this: #3629 (review)
@jepler says:

turns out that when the branch is made in adafruit/circuitpython instead of jepler/circuitpython the upload steps can be tested. Nice, I didn't realize that.

@jepler
Copy link
Author

jepler commented Nov 17, 2020

I pushed it to an adafruit branch as well, run results will be at https://github.com/adafruit/circuitpython/actions/runs/368709935

@dhalbert dhalbert self-requested a review November 17, 2020 20:22
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploads in adafruit branch build look fine! Thanks for doing this!

@jepler jepler marked this pull request as ready for review November 17, 2020 21:12
@jepler
Copy link
Author

jepler commented Nov 17, 2020

@dhalbert excellent. Looks like you have to re-review since I had entered this in draft state

@dhalbert
Copy link
Collaborator

I think it's not green just because of the one failing build (which is just network trouble).

@jepler jepler changed the title see what happens if workflows move to ubuntu 20.04 Switch our workflows to ubuntu 20.04 Nov 17, 2020
@jepler jepler merged commit 226715b into adafruit:main Nov 18, 2020
@jepler jepler deleted the try-ubuntu-20.04 branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants