Silabs xG24 devkits ports #7833

silabs-BelaV · 2023-04-04T07:26:06Z

Peripheral and Bluetooth support for xG24 explorer kit, xG24 devkit and Sparkfun Thingplus Matter MGM240 board.
Please refer to README.md in ports/silabs for the list of supported modules.

Build immediately after slc generate

tannewt · 2023-04-04T16:30:22Z

Thank you for opening this pull request! I've ordered the boards so I have ones here to test with. The Discord is the best place to get help with the CI: https://adafru.it/discord

tannewt · 2023-04-05T16:16:49Z

Don't these devices have native USB? You should provide USB VID and PID for them. The creation IDs will be derived from them. No need to add them explicitly.

dhalbert

Wow! This is an amazing amount of work. My comments are mostly style, because I don't have a board to test.

ports/silabs/Makefile

dhalbert · 2023-04-05T17:29:10Z

ports/silabs/boards/devkit_xg24_brd2601b/MX25R3235F.toml

+# Settings for the Macronix MX25R3235F 32MiB SPI flash.
+# Datasheet: https://www.macronix.com/Lists/Datasheet/Attachments/8385/MX25R3235F,%20Wide%20Range,%2032Mb,%20v1.0.pdf
+# By default its in lower power mode which can only do 8mhz. In high power mode it can do 80mhz.
+total_size = 0x2000000 # 32 MiB
+start_up_time_us = 5000
+manufacturer_id = 0xc2
+memory_type = 0x28
+capacity = 0x16
+max_clock_speed_mhz = 8
+quad_enable_bit_mask = 0x40
+has_sector_protection = false


How about submitting this to https://github.com/adafruit/nvm.toml so it can be used by anyone?

ports/silabs/boards/devkit_xg24_brd2601b/mpconfigboard.mk

ports/silabs/boards/sparkfun_thingplus_matter_mgm240p_brd2704a/board.c

dhalbert · 2023-04-05T17:35:27Z

ports/silabs/boards/sparkfun_thingplus_matter_mgm240p_brd2704a/mpconfigboard.mk

+CIRCUITPY_USB = 0
+CIRCUITPY_BUSIO = 1
+CIRCUITPY_BLEIO = 1
+CIRCUITPY_NEOPIXEL_WRITE = 0
+CIRCUITPY_FRAMEBUFFERIO = 1
+CIRCUITPY_PULSEIO = 0
+CIRCUITPY_PWMIO = 1
+CIRCUITPY_DISPLAYIO = 1
+CIRCUITPY_BLEIO_HCI = 0
+CIRCUITPY_SDCARDIO = 1
+CIRCUITPY_I2CTARGET = 0
+CIRCUITPY_DIGITALIO = 1
+CIRCUITPY_ANALOGIO = 1


Alphabetize

dhalbert · 2023-04-05T18:11:30Z

ports/silabs/common-hal/watchdog/WatchDogTimer.c

+
+void common_hal_watchdog_set_timeout(watchdog_watchdogtimer_obj_t *self,
+    mp_float_t new_timeout) {
+    if ((uint64_t)new_timeout > 256) {


I'd do a float comparison here, because some floats will not fit even in 64 bits.

ports/silabs/common-hal/watchdog/WatchDogTimer.c

dhalbert · 2023-04-05T18:14:56Z

ports/silabs/mpconfigport.mk

+        CIRCUITPY_I2CPERIPHERAL ?= 0
+        CIRCUITPY_ROTARYIO ?= 0
+        USB_NUM_ENDPOINT_PAIRS = 0
+        UF2_FAMILY_ID ?= 0x57755a57


I'm confused; I thought these boards don't have native USB support, so there is no UF2 support?

ports/silabs/mpconfigport.mk

ports/silabs/tools/slc_cli_linux/slc_cli_00.zip

silabs-ChatNguyen · 2023-04-06T07:32:52Z

Hello @dhalbert , @tannewt,
Thanks for your review. I will improve them and commit again.
I have a question about building CI. Set matrix run failed.
Can we run the ci_set_matrix.py file locally before committing? Do you have any suggestions for me?

tannewt · 2023-04-06T17:05:38Z

Hello @dhalbert , @tannewt, Thanks for your review. I will improve them and commit again. I have a question about building CI. Set matrix run failed. Can we run the ci_set_matrix.py file locally before committing? Do you have any suggestions for me?

I just ran it locally from the main branch.

I think you need to add the silabs port to this list: https://github.com/adafruit/circuitpython/blob/main/docs/shared_bindings_matrix.py#L34

When it comes to CI fixes, I generally just test by pushing. That way it'll match it is run in reality.

RetiredWizard · 2023-04-11T00:21:22Z

I am trying to build from this PR and got the following:

In file included from ../../py/obj.h:33,
                 from ./mphalport.h:30,
                 from ../../py/mphal.h:35,
                 from ./common-hal/microcontroller/Pin.h:30,
                 from ../../shared-bindings/microcontroller/Pin.h:30,
                 from /home/pi/circuitpython/ports/silabs/gecko_sdk/../boards/sparkfun_thingplus_matter_mgm240p_brd2704a/board.c:28:
../../py/qstr.h:42:14: fatal error: genhdr/qstrdefs.enum.h: No such file or directory
   42 |     #include "genhdr/qstrdefs.enum.h"
      |              ^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

I am using the Debian 10.2.1 202110110 gcc rather than gcc-arm-none-eabi-10.3-2021.10-x86_64-linux specified in the readme but that doesn't look to me like the problem here.

silabs-ChatNguyen · 2023-04-11T07:26:30Z

RetiredWi
Hi @RetiredWizard
Could you pull code and try again with ubuntu or rebuild without option -j ?
make BOARD=explorerkit_xg24_brd2703a slc-clean (clean code)
make BOARD=explorerkit_xg24_brd2703a V=2 (without -j )

tannewt · 2023-04-11T17:25:46Z

To fix the doc build, you'll want to exclude your directory from ReadTheDocs here: https://github.com/adafruit/circuitpython/blob/main/conf.py#L167

RetiredWizard · 2023-04-13T02:15:04Z

Thanks @silabs-ChatNguyen, sorry for my delayed response. This week is a bit hectic with some travel thrown in the mix. It doesn't look like I'll be back home again to pick this up until early next week.

Could you pull code and try again with ubuntu or rebuild without option -j ?
make BOARD=explorerkit_xg24_brd2703a slc-clean (clean code)
make BOARD=explorerkit_xg24_brd2703a V=2 (without -j )

I did pull the code again this evening and tried without the -j option. I think the build got further this time:

arm-none-eabi-gcc -mcpu=cortex-m33 -mthumb -mfpu=fpv5-sp-d16 -mfloat-abi=hard -T"build-sparkfun_thingplus_matter_mgm240p_brd2704a/autogen/linkerfile.ld" --specs=nano.specs -Xlinker -Map=build-sparkfun_thingplus_matter_mgm240p_brd2704a/circuitpython_efr32.map -Wl,--gc-sections @build-sparkfun_thingplus_matter_mgm240p_brd2704a/linker_objs -Wl,--start-group -lgcc -lc -lm -lnosys /home/pi/circuitpython/ports/silabs/gecko_sdk/protocol/bluetooth/lib/EFR32MG24/GCC/libbluetooth.a /home/pi/circuitpython/ports/silabs/gecko_sdk/platform/emdrv/nvm3/lib/libnvm3_CM33_gcc.a /home/pi/circuitpython/ports/silabs/gecko_sdk/platform/radio/rail_lib/autogen/librail_release/librail_config_mgm240pb32vna_gcc.a /home/pi/circuitpython/ports/silabs/gecko_sdk/platform/radio/rail_lib/autogen/librail_release/librail_multiprotocol_module_efr32xg24_gcc_release.a -Wl,--end-group -o build-sparkfun_thingplus_matter_mgm240p_brd2704a/firmware.out
/home/pi/bin/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld:/home/pi/circuitpython/ports/silabs/gecko_sdk/protocol/bluetooth/lib/EFR32MG24/GCC/libbluetooth.a: file format not recognized; treating as linker script
/home/pi/bin/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld:/home/pi/circuitpython/ports/silabs/gecko_sdk/protocol/bluetooth/lib/EFR32MG24/GCC/libbluetooth.a:1: syntax error
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:198: build-sparkfun_thingplus_matter_mgm240p_brd2704a/firmware.out] Error 1
make: *** [Makefile:64: build-sparkfun_thingplus_matter_mgm240p_brd2704a/firmware.bin] Error 2

silabs-ChatNguyen · 2023-04-14T09:25:49Z

Thanks @silabs-ChatNguyen, sorry for my delayed response. This week is a bit hectic with some travel thrown in the mix. It doesn't look like I'll be back home again to pick this up until early next week.

Could you pull code and try again with ubuntu or rebuild without option -j ?
make BOARD=explorerkit_xg24_brd2703a slc-clean (clean code)
make BOARD=explorerkit_xg24_brd2703a V=2 (without -j )

I did pull the code again this evening and tried without the -j option. I think the build got further this time:

arm-none-eabi-gcc -mcpu=cortex-m33 -mthumb -mfpu=fpv5-sp-d16 -mfloat-abi=hard -T"build-sparkfun_thingplus_matter_mgm240p_brd2704a/autogen/linkerfile.ld" --specs=nano.specs -Xlinker -Map=build-sparkfun_thingplus_matter_mgm240p_brd2704a/circuitpython_efr32.map -Wl,--gc-sections @build-sparkfun_thingplus_matter_mgm240p_brd2704a/linker_objs -Wl,--start-group -lgcc -lc -lm -lnosys /home/pi/circuitpython/ports/silabs/gecko_sdk/protocol/bluetooth/lib/EFR32MG24/GCC/libbluetooth.a /home/pi/circuitpython/ports/silabs/gecko_sdk/platform/emdrv/nvm3/lib/libnvm3_CM33_gcc.a /home/pi/circuitpython/ports/silabs/gecko_sdk/platform/radio/rail_lib/autogen/librail_release/librail_config_mgm240pb32vna_gcc.a /home/pi/circuitpython/ports/silabs/gecko_sdk/platform/radio/rail_lib/autogen/librail_release/librail_multiprotocol_module_efr32xg24_gcc_release.a -Wl,--end-group -o build-sparkfun_thingplus_matter_mgm240p_brd2704a/firmware.out
/home/pi/bin/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld:/home/pi/circuitpython/ports/silabs/gecko_sdk/protocol/bluetooth/lib/EFR32MG24/GCC/libbluetooth.a: file format not recognized; treating as linker script
/home/pi/bin/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld:/home/pi/circuitpython/ports/silabs/gecko_sdk/protocol/bluetooth/lib/EFR32MG24/GCC/libbluetooth.a:1: syntax error
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:198: build-sparkfun_thingplus_matter_mgm240p_brd2704a/firmware.out] Error 1
make: *** [Makefile:64: build-sparkfun_thingplus_matter_mgm240p_brd2704a/firmware.bin] Error 2

Hello @RetiredWizard
Seem to have a problem when cloning libbluetooth.a file.
You should install git LFS before cloning submodule gecko_sdk.
Please remove submodule gecko_sdk, install git LFS and clone again.

RetiredWizard · 2023-04-15T23:51:44Z

@silabs-ChatNguyen Thanks! that did it 😄

Adafruit CircuitPython 8.1.0-beta.0-68-g5c4dfcf59-dirty on 2023-04-15; Sparkfun Thing Plus MGM240P with MGM240PB32VNA

silabs-ChatNguyen · 2023-04-17T07:47:37Z

Hello @dhalbert,
I have made some changes based on your previous feedback.
Could you help me to review it again?
Thank you in advance!

dhalbert

Thank you! -- just a request for three trivial alphabetizations.

docs/shared_bindings_matrix.py

conf.py

tools/ci_fetch_deps.py

silabs-ChatNguyen · 2023-04-17T16:12:30Z

Thank you! -- just a request for three trivial alphabetizations.
Hi @dhalbert @tannewt
I have alphabetized them.
Unfortunately, build CI/docs failed, CI has problems when downloading some required packages.

Could you help me to fix this problem?

tannewt · 2023-04-17T16:24:59Z

@silabs-ChatNguyen I reran it. This can happen because GitHub Actions is unreliable.

silabs-ChatNguyen · 2023-04-17T17:30:33Z

@tannewt Still fail. Seem CI needs to update the package cache (sudo apt update) before installing the package.

dhalbert · 2023-04-17T20:50:15Z

The GitHub Actions bug is a GitHub problem; there's an issue about it: actions/runner-images#7452. I'll merge now anyway, because this should be a transient problem.

dhalbert

Thank you for this excellent PR!

dhalbert · 2023-04-17T23:26:03Z

@silabs-BelaV @silabs-ChatNguyen I merged this PR, and then realized that the ports/silabs/tools/slc_cli_linux/* files were 150MB. That is much larger than anything else in this repo. We would really like these files to be somewhere else. Do you have another repo you can submodule them from, or just fetch them as necessary in the Makefile, say?

I undid the merge commit by force-pushing to get rid of the history with these files.

silabs-BelaV · 2023-04-18T13:13:06Z

@dhalbert @tannewt @RetiredWizard We appreciate your quick and extensive assistance to merge our pull request, and we are thrilled to have made it to this stage. Our new Pull Request for submoduling the ports/silabs/tools/slc_cli_linux/ is created: #7874

silabs-ChatNguyen added 6 commits March 28, 2023 11:44

Initial commit for xg24

2ac5a20

Fix SLC issue

87c407d

Fix SLC extract fail

454219e

Change board's name

0cdd001

Correct spelling of code

f6c0c16

Build immediately after slc generate

Remove VID and PID

181a93f

silabs-ChatNguyen added 2 commits April 5, 2023 10:17

Change creator and creation id

70d9a2e

Apply new creator_id and creation_id

8181c5f

dhalbert requested changes Apr 5, 2023

View reviewed changes

silabs-ChatNguyen added 3 commits April 11, 2023 10:59

Update makefile, error message, mcu_processor function

a337d20

Update mpconfigboard.mk

187fafe

Update Board extensions, PORT_DEPS

c7897d5

silabs-ChatNguyen and others added 2 commits April 11, 2023 20:47

Update makefile

8f3b3d5

Add exclude_patterns

bf99e06

silabs-ChatNguyen added 3 commits April 12, 2023 01:40

Show java, jinja2 version

fd80a62

Show path for debugging CI

5148dab

Add requirements-dev for slc

50d82ef

silabs-ChatNguyen and others added 5 commits April 13, 2023 10:43

Add PATH slc_cli

dfa7570

Merge branch 'adafruit:main' into main

2d7886a

Update background function

28bdd38

Add jinja2 PATH

256f7b0

Show PATH

7e04ea6

silabs-ChatNguyen added 7 commits April 13, 2023 14:03

Update jinja2 path

2626e1a

Update jinja2 path

439c674

Update jinja2 path

9df750f

Update jinja2 path

82d7c57

Change slc folder

87a498e

Change markupsafe folder

4f3bd4b

Add symbolic link for slc

5c4dfcf

tannewt requested a review from dhalbert April 13, 2023 16:53

silabs-ChatNguyen added 2 commits April 14, 2023 11:07

Update makefile

f387673

Update makefile

118e698

This was referenced Apr 14, 2023

Add Macronix MX25R3235F SPI flash adafruit/nvm.toml#13

Merged

Add Silabs boards creationid/creators#39

Merged

Update MX25R3235F.toml from submodule nvm.toml

38c6005

dhalbert requested changes Apr 17, 2023

View reviewed changes

docs/shared_bindings_matrix.py Show resolved Hide resolved

conf.py Outdated Show resolved Hide resolved

tools/ci_fetch_deps.py Outdated Show resolved Hide resolved

alphabetize the list

40bc6aa

tannewt requested a review from dhalbert April 17, 2023 15:44

dhalbert approved these changes Apr 17, 2023

View reviewed changes

dhalbert merged commit 1669c56 into adafruit:main Apr 17, 2023

silabs-BelaV mentioned this pull request Apr 18, 2023

Silabs' new Pull Request for submoduling the ports/silabs/tools/slc_cli_linux/ #7874

Merged

Silabs xG24 devkits ports #7833

Silabs xG24 devkits ports #7833

Uh oh!

Conversation

silabs-BelaV commented Apr 4, 2023

Uh oh!

tannewt commented Apr 4, 2023

Uh oh!

tannewt commented Apr 5, 2023

Uh oh!

dhalbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dhalbert Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dhalbert Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

dhalbert Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dhalbert Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

silabs-ChatNguyen commented Apr 6, 2023

Uh oh!

tannewt commented Apr 6, 2023

Uh oh!

RetiredWizard commented Apr 11, 2023

Uh oh!

silabs-ChatNguyen commented Apr 11, 2023

Uh oh!

tannewt commented Apr 11, 2023

Uh oh!

RetiredWizard commented Apr 13, 2023

Uh oh!

silabs-ChatNguyen commented Apr 14, 2023

Uh oh!

RetiredWizard commented Apr 15, 2023

Uh oh!

silabs-ChatNguyen commented Apr 17, 2023

Uh oh!

dhalbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silabs-ChatNguyen commented Apr 17, 2023

Uh oh!

tannewt commented Apr 17, 2023

Uh oh!

silabs-ChatNguyen commented Apr 17, 2023

Uh oh!

dhalbert commented Apr 17, 2023

Uh oh!

dhalbert left a comment

Choose a reason for hiding this comment

Uh oh!

dhalbert commented Apr 17, 2023

Uh oh!

silabs-BelaV commented Apr 18, 2023

Uh oh!

Uh oh!