-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Silabs' new Pull Request for submoduling the ports/silabs/tools/slc_cli_linux/ #7874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build immediately after slc generate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience with this, and for doing the submoduling. This PR does still have at least one commit (50d82ef) in it that adds the original .zip files (and then one that takes them away). So after a regular merge, the intermediate commit will still be in the history, and the .zip files will be part of the history, and will get fetched when the repo is cloned.
I think we could do a squash merge (these are currently disabled on this repo), and get rid of the intermediate commits. Or you could do a squash rebase in your current branch and then make a new PR. How comfortable do you feel about either of these?
It's good to create a branch for all PR's, instead of working in main
. That way your main
does not get out of sync with upstream main. (https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github/always-work-on-a-branch)
Brought this in up in our discord #help-with-git: https://discord.com/channels/327254708534116352/763904151155245066/1097885610133422120 |
Don't do extra work yet, because I think the squash merge on our end may be easiest, once I confirm it's OK. |
I did a test build and got this error. Only extra thing I did beforehand was
|
@dhalbert Have problem when cloning libbluetooth.a file. |
All set, built successfully, thanks! |
In the #7833, the following were commented:
"The ports/silabs/tools/slc_cli_linux/* files were 150MB. That is much larger than anything else in this repo. We would really like these files to be somewhere else."
We are submoduling the ports/silabs/tools/slc_cli_linux/