Skip to content

Micro optimization: move Python version check from function exection time to import time #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2021

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Sep 4, 2021

No description provided.

@asvetlov
Copy link
Member Author

asvetlov commented Sep 4, 2021

The change is very subtle, I don't expect the real speedup for real applications (not benchmarks).
On the other hand, the PR is clear and obvious, it doesn't make the code harder.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #236 (8266352) into master (9ea9f9b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          107       109    +2     
  Branches        16        16           
=========================================
+ Hits           107       109    +2     
Flag Coverage Δ
unit 98.16% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
async_timeout/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea9f9b...8266352. Read the comment docs.

@asvetlov asvetlov merged commit 97b3681 into master Nov 1, 2021
@asvetlov asvetlov deleted the micro-optimization branch November 1, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant