Skip to content

Micro optimization: move Python version check from function exection time to import time #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Micro optimization: move Python version check from function exection time to import time #236

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4f1e99
Micro-optimization: move Python version check from function exection …
asvetlov Sep 4, 2021
1ab08ee
Micro-optimization: move Python version check from function exection …
asvetlov Sep 4, 2021
00592cb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 4, 2021
8266352
Merge branch 'master' into micro-optimization
asvetlov Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions async_timeout/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,17 +205,27 @@ def _on_timeout(self, task: "asyncio.Task[None]") -> None:
self._state = _State.TIMEOUT


def _current_task(loop: asyncio.AbstractEventLoop) -> "Optional[asyncio.Task[Any]]":
if sys.version_info >= (3, 7):
if sys.version_info >= (3, 7):

def _current_task(loop: asyncio.AbstractEventLoop) -> "Optional[asyncio.Task[Any]]":
return asyncio.current_task(loop=loop)
else:


else:

def _current_task(loop: asyncio.AbstractEventLoop) -> "Optional[asyncio.Task[Any]]":
return asyncio.Task.current_task(loop=loop)


def _get_running_loop() -> asyncio.AbstractEventLoop:
if sys.version_info >= (3, 7):
if sys.version_info >= (3, 7):

def _get_running_loop() -> asyncio.AbstractEventLoop:
return asyncio.get_running_loop()
else:


else:

def _get_running_loop() -> asyncio.AbstractEventLoop:
loop = asyncio.get_event_loop()
if not loop.is_running():
raise RuntimeError("no running event loop")
Expand Down