-
Notifications
You must be signed in to change notification settings - Fork 223
chore(release): small tweaks #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
# algoliasearch contributing guide | ||
|
||
Hello and welcome to the contributing guide for algoliasearch. Thanks for considering participating in our project 🙇 | ||
|
||
If this guide does not contain what you are looking for and thus prevents you from contributing, don't hesitate to leave a message on the [community forum](https://discourse.algolia.com/) or to [open an issue](https://github.com/algolia/algoliasearch-client-javascript/issues). | ||
|
||
## Reporting an issue | ||
|
||
Opening an issue is very effective way to contribute because many users might also be impacted. We'll make sure to fix it quickly if it's technically feasible and doesn't have important side effects for other users. | ||
|
||
Before reporting an issue, first check that there is not an already open issue for the same topic using the [issues page](https://github.com/algolia/algoliasearch-client-javascript/issues). Don't hesitate to thumb up an issue that corresponds to the problem you have. | ||
|
||
Another element that will help us go faster at solving the issue is to provide a reproducible test case. | ||
|
||
## The code contribution process | ||
|
||
algoliasearch is developed in TypeScript. For any code contribution, you need to: | ||
|
||
- Fork and clone the project | ||
- Create a new branch for what you want to solve (fix/_issue-number_, feat/_name-of-the-feature_) | ||
- Make your changes | ||
- Open a pull request | ||
|
||
Depending on what you're working on, you might consider different [base branches](#branch-organization). | ||
|
||
Then: | ||
|
||
- Peer review of the pull request (by at least one of the core contributors) | ||
- Automatic checks (tests, [commits](#commit-conventions), [linters](#linting)) | ||
- When everything is green, your contribution is merged 🚀 | ||
|
||
## Commit conventions | ||
|
||
This project follows the [conventional changelog](https://conventionalcommits.org/) approach. This means that all commit messages should be formatted using the following scheme: | ||
|
||
``` | ||
type(scope): description | ||
``` | ||
|
||
In most cases, we use the following types: | ||
|
||
- `fix`: for any resolution of an issue (identified or not) | ||
- `feat`: for any new feature | ||
- `refactor`: for any code change that neither adds a feature nor fixes an issue | ||
- `docs`: for any documentation change or addition | ||
- `chore`: for anything that is not related to the library itself (doc, tooling) | ||
|
||
Even though the scope is optional, we try to fill it in as it helps us better understand the impact of a change. We either use the name of the widget/connector/component impacted or we use impact topic (e.g. `docs`, `tooling`, `deps`, `ci`). | ||
|
||
Finally, if your work is based on an issue on GitHub, please add in the body of the commit message "fix #1234" if it solves the issue #1234 (read "[Closing issues using keywords](https://help.github.com/en/articles/closing-issues-using-keywords)"). | ||
|
||
Some examples of valid commit messages (used as first lines): | ||
|
||
> - fix(searchbox): increase magnifying glass size | ||
> - chore(deps): update dependency rollup-plugin-babel to v3.0.7 | ||
> - fix(connectRefinementList): set default value for limit | ||
> - chore: reword contributions guides | ||
|
||
## Branch organization | ||
|
||
The project is based on the classic GitHub flow: | ||
|
||
- `master` for the current version being worked on – Pull requests for bugs and feature related to the current major version should be created against this branch | ||
- `vX` for each major version (`X` being a number) – Pull requests for critical bug fixes should be created against this branch | ||
|
||
Most of the time, your pull requests should target the `master` branch. | ||
|
||
_Note that no new features will be developed or backported for the `vX` branches._ | ||
|
||
## Requirements | ||
|
||
To run this project, you will need: | ||
|
||
- Node.js ≥ 12 (current stable version) – [nvm](https://github.com/creationix/nvm#install-script) is recommended | ||
- [Yarn](https://yarnpkg.com) | ||
|
||
## Linting | ||
|
||
Linters are static checkers for code. They help us maintain a consistent code base. They are used for JavaScript and TypeScript files. | ||
|
||
If your editor support them, then you will see the errors directly there. You can also run them using your command line: | ||
|
||
```sh | ||
yarn lint | ||
``` | ||
|
||
TypeScript files are validated using a combination of [Prettier](https://github.com/prettier/prettier) (strict syntax form) and [ESLint](https://github.com/eslint/eslint) rules (for common mistakes and patterns). We also use [API extractor](https://api-extractor.com) to validate the correct exported types. | ||
|
||
## Release | ||
|
||
### Main version | ||
|
||
To release a stable version, go on `master` (`git checkout master`) and use: | ||
|
||
```sh | ||
npm run release | ||
``` | ||
|
||
If you're part of the Algolia team, you can read more details [here](https://github.com/algolia/doc-api-clients-squad/blob/master/release/javascript-v4.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.