Skip to content

fix(log-type-inner-queries): apply snake_case #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020
Merged

fix(log-type-inner-queries): apply snake_case #1166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abcea1a
fix(log-type-inner-queries): apply snake_case
nunomaduro Jun 9, 2020
58e016d
fix(log-inner-queries-type): makes user_token optional
nunomaduro Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/client-search/src/types/Log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ export type Log = {
/**
* Index name of the query.
*/
readonly indexName: string;
readonly index_name: string;

/**
* Query ID of the query.
*/
readonly queryID?: string;
readonly query_id?: string;

/**
* The offset of the query.
Expand All @@ -91,6 +91,6 @@ export type Log = {
/**
* The user token of the query.
*/
readonly userToken: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userToken is optional

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean user_token right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, can you validate the pull request please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, user_token sorry.

readonly user_token?: string;
}>;
};