Skip to content

chore: add-homepage-to-package.json #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Adnan-Bacic
Copy link
Contributor

in vscode for example, the homepage field will show when you hover over a library name in our own package.json

@@ -2,6 +2,7 @@
"version": "4.24.0",
"private": true,
"license": "MIT",
"homepage": "https://github.com/algolia/algoliasearch-client-javascript#readme",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be in the package.json of algoliasearch instead of the root one? Also I wonder if it shouldn't be the documentation link instead, as the repo is already linked too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes plus it's targeting v4, we don't release anything on this version except security/bug fixes

@Adnan-Bacic would you mind porting the PRs to https://github.com/algolia/api-clients-automation instead?

Copy link
Contributor Author

@Adnan-Bacic Adnan-Bacic Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont quite understand why in that repo, but okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole repository is generated, and the source is from https://github.com/algolia/api-clients-automation, once your other PR is merged it will be reflected here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants