Skip to content

chore: add-homepage-to-package.json #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: add-homepage-to-package.json #1504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dbb0c1
added homepage to package.json
Adnan-Bacic Jan 22, 2024
48372bc
Merge branch 'v4' into chore-add-homepage-to-package.json
Adnan-Bacic Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"version": "4.24.0",
"private": true,
"license": "MIT",
"homepage": "https://github.com/algolia/algoliasearch-client-javascript#readme",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be in the package.json of algoliasearch instead of the root one? Also I wonder if it shouldn't be the documentation link instead, as the repo is already linked too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes plus it's targeting v4, we don't release anything on this version except security/bug fixes

@Adnan-Bacic would you mind porting the PRs to https://github.com/algolia/api-clients-automation instead?

Copy link
Contributor Author

@Adnan-Bacic Adnan-Bacic Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont quite understand why in that repo, but okay

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole repository is generated, and the source is from https://github.com/algolia/api-clients-automation, once your other PR is merged it will be reflected here

"workspaces": [
"packages/*"
],
Expand Down