Skip to content

docs: SLA page and unstable for prereleases #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 17, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2453

Changes included:

  • adds a -gg flag for the release, in order to generate the current state PNGs
  • do not set prereleases as actively supported SLA versions
  • update the active period to 2 years
  • patch the lts package to make it suit our needs (I'll document the commands in our contributing guides)
  • move generated PNGs to the website folder in order to render a single page for all of them for legal checks

@shortcuts shortcuts self-assigned this Jun 17, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 17, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

github-actions bot commented Jun 17, 2024

@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 10:15 Inactive
@shortcuts shortcuts marked this pull request as ready for review June 17, 2024 10:15
@shortcuts shortcuts requested a review from a team as a code owner June 17, 2024 10:15
@shortcuts shortcuts requested review from morganleroi and Fluf22 June 17, 2024 10:15
@Fluf22
Copy link
Contributor

Fluf22 commented Jun 17, 2024

It added Main on all gen images 🫤

@shortcuts
Copy link
Member Author

It added Main on all gen images 🫤

yes it's expected to highlight that the non-released versions are not supported, wdyt?

if (active !== null) {
if (active < queryEnd && end > queryStart) {
- output.push({ name, type: 'active', start: active, end });
+ output.push({ name, type: isPreRelease ? 'unstable' : 'active', start: active, end });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is unstable a common word for releases ? I feel like DEVELOPMENT and MAINTENANCE would be more suitable

Copy link
Member Author

@shortcuts shortcuts Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used the same as for https://nodejs.org/en/about/previous-releases

maintenance in our SLA policy means that there's no features but fixes will be delivered

@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 11:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 12:20 Inactive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for dart main is stable, its the lastest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but here main refers to the unreleased versions, so non stable you know the commits in between releases

@shortcuts shortcuts requested a review from millotp June 17, 2024 14:45
@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 14:59 Inactive
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automation to the max

@shortcuts shortcuts enabled auto-merge (squash) June 17, 2024 15:40
@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 15:55 Inactive
@shortcuts shortcuts merged commit cefa667 into main Jun 17, 2024
21 checks passed
@shortcuts shortcuts deleted the chore/sla-markdown branch June 17, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants