-
Notifications
You must be signed in to change notification settings - Fork 21
docs: SLA page and unstable for prereleases #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c2e5891
docs: SLA page and unstable for prereleases
shortcuts 4d71e58
chore: commit patches
shortcuts 07451be
fix: all kind of prereleases
shortcuts 32dfb48
chore: update patch
shortcuts 603abb5
chore: update patch
shortcuts 659beab
docs: document release cli
shortcuts fc78845
docs: document lts
shortcuts 1a9cfa7
fix: it's lts not active
shortcuts 4a17706
chore: comments
shortcuts 56e0ee3
chore: rename lts to sla because... it's really sla
shortcuts 92ca62c
Merge branch 'main' into chore/sla-markdown
shortcuts 7f53d10
docs: SLA terms
shortcuts ed7d3cd
Merge branch 'main' into chore/sla-markdown
shortcuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ debug.log | |
**/.yarn/* | ||
!**/.yarn/releases | ||
!**/.yarn/plugins | ||
!**/.yarn/patches | ||
|
||
.vscode/ | ||
.idea/ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
diff --git a/lib/index.js b/lib/index.js | ||
index 483d41fe6e4b52f4d2210452a2f2e528e324a6f3..c8852f31dd5b40b706ac91254ef38f9a4eb7f154 100644 | ||
--- a/lib/index.js | ||
+++ b/lib/index.js | ||
@@ -45,10 +45,11 @@ function parseInput (data, queryStart, queryEnd, excludeMaster, projectName) { | ||
Object.keys(data).forEach((v) => { | ||
const version = data[v]; | ||
const name = `${projectName} ${v.replace('v', '')}`; | ||
- const current = version.start ? new Date(version.start) : null; | ||
- const active = version.lts ? new Date(version.lts) : null; | ||
- const maint = version.maintenance ? new Date(version.maintenance) : null; | ||
- let end = version.end ? new Date(version.end) : null; | ||
+ const isPreRelease = version.prerelease === true; | ||
+ const current = isPreRelease ? queryStart : version.start ? new Date(version.start) : null; | ||
+ const active = isPreRelease ? queryStart : version.lts ? new Date(version.lts) : null; | ||
+ const maint = isPreRelease ? queryStart : version.maintenance ? new Date(version.maintenance) : null; | ||
+ let end = isPreRelease ? queryEnd : version.end ? new Date(version.end) : null; | ||
|
||
if (current === null) { | ||
throw new Error(`missing start in ${version}`); | ||
@@ -60,7 +61,7 @@ function parseInput (data, queryStart, queryEnd, excludeMaster, projectName) { | ||
|
||
if (maint !== null) { | ||
if (maint < queryEnd && end > queryStart) { | ||
- output.push({ name, type: 'maintenance', start: maint, end }); | ||
+ output.push({ name, type: isPreRelease ? 'unstable' : 'maintenance', start: maint, end }); | ||
} | ||
|
||
end = maint; | ||
@@ -68,20 +69,20 @@ function parseInput (data, queryStart, queryEnd, excludeMaster, projectName) { | ||
|
||
if (active !== null) { | ||
if (active < queryEnd && end > queryStart) { | ||
- output.push({ name, type: 'active', start: active, end }); | ||
+ output.push({ name, type: isPreRelease ? 'unstable' : 'active', start: active, end }); | ||
} | ||
|
||
end = active; | ||
} | ||
|
||
if (current < queryEnd && end > queryStart) { | ||
- output.push({ name, type: 'current', start: current, end }); | ||
+ output.push({ name, type: isPreRelease ? 'unstable' : 'current', start: current, end }); | ||
} | ||
}); | ||
|
||
if (!excludeMaster) { | ||
output.unshift({ | ||
- name: 'Master', | ||
+ name: 'Main', | ||
type: 'unstable', | ||
start: queryStart, | ||
end: queryEnd |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,126 +22,132 @@ | |
"name": "algolia-bot", | ||
"email": "[email protected]" | ||
}, | ||
"lts": { | ||
"sla": { | ||
"csharp": { | ||
"6.1.17": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"7.0.0-beta.4": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2026-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"dart": { | ||
"1.11.1": { | ||
"start": "2024-06-12", | ||
"end": "2024-12-12" | ||
}, | ||
"1.12.0": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"lts": "2024-06-13", | ||
"end": "2026-06-13" | ||
} | ||
}, | ||
"go": { | ||
"3.31.1": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"4.0.0-beta.16": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2025-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"java": { | ||
"3.16.9": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"4.0.0-beta.34": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2025-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"javascript": { | ||
"4.23.3": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"5.0.0-beta.4": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2025-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"kotlin": { | ||
"2.1.12": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"3.0.0-beta.29": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2025-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"php": { | ||
"3.4.1": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"4.0.0-beta.4": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2025-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"python": { | ||
"3.0.0": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"4.0.0b19": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2025-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"ruby": { | ||
"2.3.4": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"3.0.0.beta.4": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2026-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"scala": { | ||
"1.45.2": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"2.0.0-beta.4": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2026-06-13", | ||
"prerelease": true | ||
} | ||
}, | ||
"swift": { | ||
"8.20.1": { | ||
"start": "2024-01-01", | ||
"end": "2024-08-01" | ||
"lts": "2024-01-01", | ||
"end": "2026-08-01" | ||
}, | ||
"9.0.0-beta.4": { | ||
"start": "2024-06-13", | ||
"active": "2024-06-13", | ||
"end": "2025-06-13" | ||
"end": "2026-06-13", | ||
"prerelease": true | ||
} | ||
} | ||
} | ||
|
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
unstable
a common word for releases ? I feel likeDEVELOPMENT
andMAINTENANCE
would be more suitableUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used the same as for https://nodejs.org/en/about/previous-releases
maintenance in our SLA policy means that there's no features but fixes will be delivered