-
Notifications
You must be signed in to change notification settings - Fork 21
fix(specs): method names in breaking changes table #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No code generatedIf you believe code should've been generated, please, report the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏻
@@ -10,7 +10,6 @@ | |||
"client.getFrequentlyBoughtTogether": "client.getRecommendations", | |||
"client.getLookingSimilar": "client.getRecommendations", | |||
"client.getRecommendations": "client.getRecommendations", | |||
"client.getRecommendedForYou": "client.getRecommendations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this existed in the javascript v4 client, no? @kai687
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't documented publicly, so I thought we can just not include this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's GO then
🧭 What and Why
Update the
major-breaking-changes-rename.json
file to fit the table introduced in https://github.com/algolia/doc/pull/9415index.exists
because this helper isn't documented yet. I want to add the docs for it in https://github.com/algolia/doc/pull/9420🎟 JIRA Ticket:
Changes included:
🧪 Test