Skip to content

fix(specs): method names in breaking changes table #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Oct 21, 2024

🧭 What and Why

Update the major-breaking-changes-rename.json file to fit the table introduced in https://github.com/algolia/doc/pull/9415

🎟 JIRA Ticket:

Changes included:

  • List changes

🧪 Test

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 21, 2024

No code generated

If you believe code should've been generated, please, report the issue.

@kai687 kai687 changed the title fix: method names fix(specs): method names in breaking changes table Oct 21, 2024
@kai687 kai687 marked this pull request as ready for review October 21, 2024 11:20
@kai687 kai687 requested a review from a team as a code owner October 21, 2024 11:20
@kai687 kai687 requested review from Fluf22 and shortcuts October 21, 2024 11:20
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@@ -10,7 +10,6 @@
"client.getFrequentlyBoughtTogether": "client.getRecommendations",
"client.getLookingSimilar": "client.getRecommendations",
"client.getRecommendations": "client.getRecommendations",
"client.getRecommendedForYou": "client.getRecommendations",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this existed in the javascript v4 client, no? @kai687

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't documented publicly, so I thought we can just not include this.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's GO then

@shortcuts shortcuts enabled auto-merge (squash) October 22, 2024 06:34
@shortcuts shortcuts merged commit 44e58c7 into main Oct 22, 2024
12 checks passed
@shortcuts shortcuts deleted the fix/version-table branch October 22, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants