Skip to content

chore: update major bc changes references #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

observed in https://github.com/algolia/AlgoliaWeb/pull/22965

the ruby client had a different naming so we can add it to the table as well

@shortcuts shortcuts requested a review from a team as a code owner December 2, 2024 12:38
@shortcuts shortcuts enabled auto-merge (squash) December 2, 2024 12:38
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 2, 2024

No code generated

If you believe code should've been generated, please, report the issue.

@@ -56,6 +57,7 @@
"index.deleteObjects": "client.deleteObjects",
"index.deleteRule": "client.deleteRule",
"index.deleteSynonym": "client.deleteSynonym",
"index.exists": "client.indexExists",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kai687 can we just not generate the link for it? it's still great to let users that can use an LSP/IDE benefit from the inline documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kai687

@shortcuts shortcuts self-assigned this Dec 3, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shortcuts shortcuts merged commit 7b827d2 into main Dec 18, 2024
12 checks passed
@shortcuts shortcuts deleted the chore/major-breaking-changes-renames branch December 18, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants