Skip to content

fix(specs): wrong body parameter name #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 4, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-614

Changes included:

Fixes #891

↑ The full details are in the issue ↑

We now leverage the built-in x-codegen-request-body-name property in the spec to override the automatically guessed requestBody name.

I'll update the contributing guide in the docs in #897.

πŸ§ͺ Test

CI :D

@shortcuts shortcuts requested a review from damcou August 4, 2022 10:47
@shortcuts shortcuts self-assigned this Aug 4, 2022
@netlify
Copy link

netlify bot commented Aug 4, 2022

βœ… Deploy Preview for api-clients-automation canceled.

Name Link
πŸ”¨ Latest commit 08172ad
πŸ” Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ebb78159398c0008ad2def

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 4, 2022

βœ— The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some explanations ;)

@shortcuts shortcuts merged commit 005f9ed into main Aug 4, 2022
@shortcuts shortcuts deleted the fix/specs-wrong-body-name branch August 4, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specs: model not generated for requestBody with array type
3 participants