Skip to content

docs: add troubleshooting section to contributing guide #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Follow up of the "discovery" in #896

This PR updates the contributing guide "Add a new API client" so we don't forget what is this property about

🧪 Test

Netlify preview

@shortcuts shortcuts requested a review from damcou August 4, 2022 13:08
@shortcuts shortcuts self-assigned this Aug 4, 2022
@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 64b536f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62f0d147a7c4e2000810eeed
😎 Deploy Preview https://deploy-preview-897--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 4, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.


You might want to send additional information to the generators that have no link with your REST API. To do so, you can add parameters starting with `x-` at the root level of your spec, which will be available in the mustache template under the `vendorExtensions` object.
#### Force the name of a `requestBody`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find titles with ####  hard to discern and the separation of the different troubleshooting points is not clear enough. Maybe adding a dash or a number would help ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean via the file, or the website? The preview looks nice: https://deploy-preview-897--api-clients-automation.netlify.app/docs/contributing/add-new-api-client

@shortcuts shortcuts requested a review from damcou August 8, 2022 07:39
@shortcuts shortcuts enabled auto-merge (squash) August 8, 2022 07:39
@shortcuts shortcuts force-pushed the docs/contributing-guide branch from 5febc04 to df30ed7 Compare August 8, 2022 07:47
@shortcuts shortcuts force-pushed the docs/contributing-guide branch from df30ed7 to 1b61c2f Compare August 8, 2022 09:02
@shortcuts shortcuts force-pushed the docs/contributing-guide branch from 1b61c2f to 64b536f Compare August 8, 2022 09:03
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shortcuts shortcuts merged commit ce99786 into main Aug 8, 2022
@shortcuts shortcuts deleted the docs/contributing-guide branch August 8, 2022 09:12
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 8, 2022
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants