Skip to content

chore(docker): rename the container to api-client to be less generic #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 24, 2022

🧭 What and Why

The conteneur name dev was a bit vague and could clash with other containers, renaming it to api-client avoids that

🧪 Test

yarn docker:setup

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d81ee2f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63061c57b5b9550008a7a478
😎 Deploy Preview https://deploy-preview-951--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@millotp millotp requested review from a team, damcou and shortcuts and removed request for a team August 24, 2022 12:37
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 24, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:okidoki:

@millotp millotp enabled auto-merge (squash) August 24, 2022 12:42
@millotp millotp merged commit c576b29 into main Aug 24, 2022
@millotp millotp deleted the chore/container-name branch August 24, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants