Skip to content

chore(docker): rename the container to api-client to be less generic #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022
Merged

chore(docker): rename the container to api-client to be less generic #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c7b1ce
chore(docker): rename the container to api-client to be less generic
millotp Aug 24, 2022
d81ee2f
review
millotp Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .lintstagedrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"generators/**/*.java": "docker exec -t dev yarn cli format java generators",
"generators/**/*.java": "docker exec -t api-clients-automation yarn cli format java generators",
".github/**/*.yml": "yarn github-actions:lint --fix",
"*.json": "yarn fix:json",
"scripts/**/*.(js|ts)": "yarn scripts:lint --fix"
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
"build:eslint": "yarn workspace eslint-plugin-automation-custom build && yarn install",
"clean": "rm -rf **/dist **/build **/node_modules **/.gradle **/vendor || true",
"cli": "yarn workspace scripts ts-node --transpile-only ./cli/index.ts",
"docker": "docker exec -it dev yarn cli $*",
"docker": "docker exec -it api-clients-automation yarn cli $*",
"docker:build": "./scripts/docker/build.sh",
"docker:clean": "docker stop dev; docker rm -f dev; docker image rm -f api-clients-automation",
"docker:clean": "docker stop api-clients-automation; docker rm -f api-clients-automation; docker image rm -f api-clients-automation",
"docker:mount": "./scripts/docker/mount.sh",
"docker:setup": "yarn docker:clean && yarn docker:build && yarn docker:mount",
"fix:json": "eslint --ext=json . --fix",
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker/mount.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null && pwd)/../.."

docker run -d -it --name dev --mount type=bind,source=$ROOT/,target=/app api-clients-automation
docker run -d -it --name api-clients-automation --mount type=bind,source=$ROOT/,target=/app api-clients-automation
4 changes: 2 additions & 2 deletions website/docs/contributing/setup-repository.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ yarn docker:build

#### Mount

> Mount docker image on `dev` container
> Mount docker image on `api-clients-automation` container

```bash
yarn docker:mount
```

#### Clean

> Stops `dev` container and clean the built image
> Stops `api-clients-automation` container and clean the built image

```bash
yarn docker:clean
Expand Down