Pick a reasonable default for line highlight color based on theme background color #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
added a commit
that referenced
this pull request
Jul 10, 2020
* Add concept of gutter cells * Adjust rendering and styling * Finish layout, add test, make it work with line highlighting * Fix copy and paste * Update alpha publishing to point to v3 branch * Update other v2 reference * Another 2 * Add diff highlighting line transformer (#88) * fix typo in CONTRIBUTING.md * fix formatting error preventing tests in src/utils.js * wip: diff line transformer draft implementation * add diff line transformer integration test * diffLineTransformer return new v3 gutterCells prop * readme fix typo * pick default red/green colors for diff line highlighting * fix diffLineTransformer.schemaExtension, avoid mutating input params * don't require diff lines to start with +/- * Update tests, fix type errors * Remove postfix space requirement Co-authored-by: Andrew Branch <[email protected]> * Add GraphQL testing infrastructure * Update workflows and CONTRIBUTING.md * Add missing proc.kill * Ignore tty message? * Remove meta from test query because apparently languageId isn’t stable * Totally ignore tty error * Update snapshot * Shallow checkout vscode * Pick a reasonable default for line highlight color based on theme background color (#106) * Detect dark themes by luminance * Fix dependencies * Update README * Update MIGRATING * Add test, adjust light default color * Ignore report.html * Don’t cache in GraphQL tests * Officially deprecate `codeFenceNode` * Add line number docs * Add diff highlighting docs * Remove old `colorTheme` option * Update baselines Co-authored-by: Janosh Riebesell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
Light theme users will still probably want to pick their own, as I think this is pretty ugly, but it at least lets them know their configuration isn’t broken, which is the point of #51.