v3 #108
Merged
v3 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add gutters, line number option
* fix typo in CONTRIBUTING.md * fix formatting error preventing tests in src/utils.js * wip: diff line transformer draft implementation * add diff line transformer integration test * diffLineTransformer return new v3 gutterCells prop * readme fix typo * pick default red/green colors for diff line highlighting * fix diffLineTransformer.schemaExtension, avoid mutating input params * don't require diff lines to start with +/- * Update tests, fix type errors * Remove postfix space requirement Co-authored-by: Andrew Branch <[email protected]>
Add GraphQL testing infrastructure
…kground color (#106) * Detect dark themes by luminance * Fix dependencies * Update README * Update MIGRATING * Add test, adjust light default color * Ignore report.html * Don’t cache in GraphQL tests
|
@andrewbranch That's very kind of you! Honestly no need to rush v3 on my account though. 😄 On the other hand, this way we have some nice v3 minor releases to look forward to. 🚀 |
|
Just tried out v3 on my blog. For some reason, all the empty lines are gone. Currently investigating.
|
|
Ah, so the empty lines are there. They just have 0 height. If I toggle off .grvsc-code {
display: table;
}they revert back to their former height. |
janosh
reviewed
Jul 10, 2020
|
|
||
| ### Line highlighting is visible without custom CSS. | ||
|
|
||
| Previously, the default line highlight background color was `transparent`, which meant a color had to be set with a CSS variable by the user. The reason for this limitation was that there is no sensible default that works for both light themes and dark themes, as a light highlight would be invisible on white, and a dark highlight would be invisible on black. As of v3, the plugin the luminance of each theme’s background color and selects a translucent white or translucent black highlight color as a default. |
There was a problem hiding this comment.
Missing verb here: "...the plugin the luminance of ..."
|
Oops, good catches! I’ll get a patch out momentarily. ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28,
closes #51,
closes #62,
aaand closes #96.
Didn’t get all the docs and extra fancy features in I was hoping for, but I don’t want to make @janosh wait any longer. Thanks again @janosh for contributing an awesome feature! It looks great in the README: