refactor(AMD/CommonJS exported module): Export module name #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module object When the module is imported using AMD/CommonJS, it is expected to expose its name instead of the Angular module object. This is because angular.module() expects the dependencies as string instead of actual module objects. Fix angular-slider#326. Breaking change: code that relies on the module object to be exported (accessing the name via `.name` for example) will break, since the name is now directly returned.
Current coverage is 100%@@ master #360 diff @@
====================================
Files 1 1
Lines 811 811
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 811 811
Misses 0 0
Partials 0 0
|
|
👍 |
|
Released under 5.0 version ;) |
|
Merci Valentin ! ;) Thanks for being that reactive ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the module is imported using AMD/CommonJS, it is expected to expose its name instead of the
Angular module object. This is because angular.module() expects the dependencies as string instead
of actual module objects.
Fix #326
Breaking change: code that relies on the module object to be exported (accessing the name
via
.namefor example) will break, since the name is now directly returned.