Refactor CircleCI configuration #14687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They take a while and significantly slow down the Windows basic e2e.
This test has been disabled for a while and is in test-large instead.
filipesilva
added
the
target: patch
clydin
approved these changes
Jun 6, 2019
14 tasks
vikerman
pushed a commit
that referenced
this pull request
Jul 29, 2019
snapshots builds are required to be run when the PR is created by renovate. This is because we have renovate jobs that update the snapshots commit SHA and we want to verify that these are green prior to merging them. Related to: #14687
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full windows tests on CircleCI don't run on PRs. Here is a successful run: https://circleci.com/workflow-run/aee0dd91-ffe2-4850-aafa-59ef5d1f493a
Additional, the following CircleCI option for this project is also turned on now:
It should help reduce our total CI hours. This option is not present in the in-repo configuration, and instead can be found in https://circleci.com/gh/angular/angular-cli/edit#advanced-settings.