Skip to content

ci: enable snapshot e2e for renovate PRs #15169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019
Merged

ci: enable snapshot e2e for renovate PRs #15169

merged 1 commit into from
Jul 29, 2019

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jul 26, 2019

snapshots builds are required to be run when the PR is created by renovate. This is because we have renovate jobs that update the snapshots commit SHA and we want to verify that these are green prior to merging them.

Related to: #14687

@alan-agius4 alan-agius4 changed the title wip! ci snapshot ci: enable snapshot e2e for renovate PRs Jul 26, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review July 26, 2019 08:38
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Jul 26, 2019
@alan-agius4 alan-agius4 requested a review from filipesilva July 26, 2019 08:40
snapshots builds are required to be run when the PR is created by renovate. This is because we have renovate jobs that update the snapshots commit SHA and we want to verify that these are green prior to merging them.

Related to: #14687
@vikerman vikerman merged commit 687bc6a into angular:master Jul 29, 2019
@alan-agius4 alan-agius4 deleted the ci-snapshots-test branch July 29, 2019 19:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants