Skip to content

fix(@schematics/angular): rename the ivy-ngcc command to ngcc #15840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(@schematics/angular): rename the ivy-ngcc command to ngcc #15840

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 14, 2019

With angular/angular#33140, the Angular Compatibility Compiler executable will be renamed from ivy-ngcc to ngcc.

@gkalpak
fix(@schematics/angular): rename the ivy-ngcc command to ngcc
d58d56f 
With angular/angular#33140, the Angular Compatibility Compiler
executable will be renamed from `ivy-ngcc` to `ngcc`.
@gkalpak gkalpak added area: @schematics/angular needs: discussion On the agenda for team meeting to determine next steps action: review The PR is still awaiting reviews from at least one requested reviewer PR state: blocked labels Oct 14, 2019
@gkalpak gkalpak mentioned this pull request Oct 14, 2019
Closed
alan-agius4
alan-agius4 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than we need to wait for a FW release and update the devDependencies of @angular/ across the repo’s package.json.

@alan-agius4
Copy link
Collaborator

@gkalpak, I included this commit in one of my PR #15845 as with the next framework release we also need to address the renaming of ngComponentDef.

@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Oct 15, 2019
@gkalpak
Copy link
Member Author

gkalpak commented Oct 15, 2019

Cool! Closing in favor of #15845, then. Thx 👍

@gkalpak gkalpak closed this Oct 15, 2019
@gkalpak gkalpak deleted the fix-schematics-angular-rename-ngcc branch October 15, 2019 07:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer area: @schematics/angular
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkalpak @alan-agius4 @googlebot