fix(ngcc): rename the executable from ivy-ngcc to ngcc
#33140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
comp: ngcc
target: major
|
You can preview 179a4dd at https://pr33140-179a4dd.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-ngcc-rename-executable
branch
from
179a4dd to
3a74d6b
Compare
|
You can preview 3a74d6b at https://pr33140-3a74d6b.ngbuilds.io/. |
gkalpak
added a commit
to gkalpak/angular-cli
that referenced
this pull request
Oct 14, 2019
With angular/angular#33140, the Angular Compatibility Compiler executable will be renamed from `ivy-ngcc` to `ngcc`.
Previously, the executable for the Angular Compatibility Compiler (`ngcc`) was called `ivy-ngcc`. This would be confusing for users not familiar with our internal terminology, especially given that we call it `ngcc` in all our docs and presentations. This commit renames the executable to `ngcc` and replaces `ivy-ngcc` with a script that errors with an informative message (prompting the user to use `ngcc` instead). Jira issue: [FW-1624](https://angular-team.atlassian.net/browse/FW-1624)
gkalpak
force-pushed
the
fix-ngcc-rename-executable
branch
from
3a74d6b to
417a6fc
Compare
gkalpak
added
the
action: review
|
You can preview 417a6fc at https://pr33140-417a6fc.ngbuilds.io/. |
|
BTW, we might need more changes if #32999 lands first. |
petebacondarwin
approved these changes
Oct 14, 2019
14 tasks
IgorMinar
approved these changes
Oct 14, 2019
IgorMinar
added
action: merge
|
merge-assistance: global approval |
vikerman
pushed a commit
to vikerman/angular-cli
that referenced
this pull request
Oct 16, 2019
With angular/angular#33140, the Angular Compatibility Compiler executable will be renamed from `ivy-ngcc` to `ngcc`.
vikerman
pushed a commit
to angular/angular-cli
that referenced
this pull request
Oct 16, 2019
With angular/angular#33140, the Angular Compatibility Compiler executable will be renamed from `ivy-ngcc` to `ngcc`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the executable for the Angular Compatibility Compiler (
ngcc) was calledivy-ngcc. This would be confusing for users not familiar with our internal terminology, especially given that we call itngccin all our docs and presentations.This commit renames the executable to
ngccand replacesivy-ngccwith a script that errors with an informative message (prompting the user to usengccinstead).Jira issue: FW-1624
Related PR: angular/angular-cli#15840