Skip to content

refactor: use node v12 types, matching WORKSPACE version #17653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented May 6, 2020

The WORKSPACE was updated to use node 12 in #16976 but the type checking was still using the types for node 12. The newer typings are a bit more precise but also bring in a return type overload for fs.stat (due to {bigint: true}).

This updates existing references to node 10 to node 12, moves to the latest typings packages, selects node v12 types, and fixes type errors that arise from those changes.

For the error argument type change in node/host.ts I went for a union of the previous (wrong) type and the newly fixed type. Technically err can never be undefined but this way it's still safe to pull this code into contexts that may be using outdated versions of @types/node. A nice future cleanup would be remove the question mark on those err? arguments.

@jkrems
Copy link
Contributor Author

jkrems commented May 6, 2020

Does the build failure here mean that we'd need to land the new types in both the main repo and this one at the same time?

@alan-agius4
Copy link
Collaborator

Thanks for your contribution, however this is now obsolete.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2021
@jkrems jkrems deleted the node-v12 branch November 6, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants