More bazel tests #16976
Merged
More bazel tests #16976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
force-pushed
the
more-bazel-tests
branch
9 times, most recently
from
267a0c5 to
227aca5
Compare
filipesilva
force-pushed
the
more-bazel-tests
branch
12 times, most recently
from
ffb976f to
0e1b959
Compare
filipesilva
force-pushed
the
more-bazel-tests
branch
8 times, most recently
from
ed90a8b to
7c72c87
Compare
We shouldn't need to export this, but webpack-rollup-loader uses it.
With these in, we can't access the properties from other Bazel targets.
Contains fixes related to the symlink behaviour inside of bazel. Without it, webpack needs to be configured to be aware of symlinks and preserve the paths.
This is required so that yarn_install can add all generated & downloaded files to the generated bazel filegroups
Turns out there is a linker bug with no sandbox.
filipesilva
force-pushed
the
more-bazel-tests
branch
from
d92031a to
cbead4e
Compare
|
Per #16976 (comment) merged despite the pending statuses for removed checks. Also updated status checks to drop |
|
🎉 Nice work @filipesilva |
|
@gregmagolan you know a lot of it was you :D |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.