Skip to content

build: update to [email protected] #19345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: update to [email protected] #19345

wants to merge 1 commit into from

Conversation

jasonaden
Copy link
Contributor

No description provided.

@CaerusKaru CaerusKaru mentioned this pull request Sep 23, 2017
Closed
@jasonaden jasonaden force-pushed the upgrade_rxjs branch 2 times, most recently from 68955ba to 62f03ff Compare September 27, 2017 17:56
@mary-poppins
Copy link

You can preview 62f03ff at https://pr19345-62f03ff.ngbuilds.io/.

@jasonaden jasonaden changed the title build: update to [email protected] build: update to [email protected] Sep 27, 2017
@mary-poppins
Copy link

You can preview c4d02d2 at https://pr19345-c4d02d2.ngbuilds.io/.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mary-poppins
Copy link

You can preview 128e9c9 at https://pr19345-128e9c9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 78c1e71 at https://pr19345-78c1e71.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c2f2746 at https://pr19345-c2f2746.ngbuilds.io/.

@googlebot
Copy link

CLAs look good, thanks!

@mary-poppins
Copy link

You can preview 8140e6c at https://pr19345-8140e6c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6989e11 at https://pr19345-6989e11.ngbuilds.io/.

@mary-poppins
Copy link

You can preview fa85f20 at https://pr19345-fa85f20.ngbuilds.io/.

IgorMinar
IgorMinar suggested changes Oct 17, 2017
View reviewed changes
package.json Outdated
@@ -24,7 +24,7 @@
"dependencies": {
"core-js": "^2.4.1",
"reflect-metadata": "^0.1.3",
"rxjs": "5.x",
"rxjs": "5.5.0-beta.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta.7 is the latest

yarn.lock Outdated
resolved "https://registry.yarnpkg.com/@types/node/-/node-8.0.28.tgz#86206716f8d9251cf41692e384264cbd7058ad60"
"@types/node@*", "@types/[email protected]":
version "7.0.18"
resolved "https://registry.yarnpkg.com/@types/node/-/node-7.0.18.tgz#cd67f27d3dc0cfb746f0bdd5e086c4c5d55be173"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and many other changes in the lock file should not be here. you should be updating just the rxjs version and nothing else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm doing the upgrade with a command like this:

yarn upgrade [email protected]

After doing this, I get one line updated in package.json, and tons of updates in the yarn.lock file. Looks like it's due to Rx's dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using yarn 1.0.2?

@IgorMinar IgorMinar added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: build & ci Related the build and CI infrastructure of the project labels Oct 17, 2017
@IgorMinar IgorMinar added area: core Issues related to the framework runtime area: packaging Issues related to Angular's creation of npm packages labels Oct 17, 2017
@jasonaden jasonaden force-pushed the upgrade_rxjs branch 3 times, most recently from 132c1a3 to 07cc172 Compare October 18, 2017 16:16
@mary-poppins
Copy link

You can preview 07cc172 at https://pr19345-07cc172.ngbuilds.io/.

@jasonaden jasonaden removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 18, 2017
@mary-poppins
Copy link

You can preview 4cda80d at https://pr19345-4cda80d.ngbuilds.io/.

This was referenced Oct 18, 2017
Closed
Closed
@jasonaden jasonaden added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2017
@jasonaden jasonaden changed the title build: update to [email protected] build: update to [email protected] Oct 18, 2017
@mary-poppins
Copy link

You can preview 977f6dc at https://pr19345-977f6dc.ngbuilds.io/.

@tbosch tbosch added the target: major This PR is targeted for the next major release label Oct 18, 2017
@tbosch tbosch closed this in 7d1abd9 Oct 18, 2017
@CaerusKaru CaerusKaru mentioned this pull request Oct 21, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: core Issues related to the framework runtime area: packaging Issues related to Angular's creation of npm packages cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasonaden @mary-poppins @googlebot @IgorMinar @tbosch