feat: update to rxjs 5.5.0 and switch to lettable operators #7276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
josephperrott,
kara,
mmalerba and
tinayuangao
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
7275/rxjs-lettable
branch
3 times, most recently
from
0641f9e to
4041c43
Compare
crisbeto
added
blocked
jelbourn
approved these changes
Sep 24, 2017
|
Also blocked on rxjs 5.5 getting into google |
crisbeto
force-pushed
the
7275/rxjs-lettable
branch
from
4041c43 to
3542ed6
Compare
|
@crisbeto Is this unblocked now that angular/angular#19345 is synced? Or are we waiting for 5.0.0 final? |
CaerusKaru
reviewed
Oct 21, 2017
package.json
Outdated
| "core-js": "^2.4.1", | ||
| "rxjs": "^5.0.1", | ||
| "rxjs": "5.5.0-beta.7", |
There was a problem hiding this comment.
RxJS 5.5.0 is now out of beta, this can be set to ^5.5.0
crisbeto
force-pushed
the
7275/rxjs-lettable
branch
from
3542ed6 to
1e0ae27
Compare
crisbeto
added
P1
|
Rebased, sorted out any new usages of the |
crisbeto
force-pushed
the
7275/rxjs-lettable
branch
3 times, most recently
from
2cd7e4d to
37270c8
Compare
Bumps the required RxJS version to 5.5.0 and gets rid of our RxChain in favor of using the lettable Rx operators. Refactors all the usages and updates the configs. Fixes angular#7275.
crisbeto
force-pushed
the
7275/rxjs-lettable
branch
from
37270c8 to
711d05e
Compare
|
Awesome work! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the required RxJS version to 5.5.0 and gets rid of our RxChain in favor of using the lettable Rx operators. Refactors all the usages and updates the configs.
Fixes #7275.