build: speed-up stylesheet building #12426
Conversation
* Switches back from `dart-sass` to `node-sass` due to a pretty huge slow-down we noticed (can be revisited) * No longer copies all SCSS files to the temporary `package` output just in favor of the demo-app (slows down unnecessarily). This now allows us to live-reload theme changes within a second. * No longer rebuilds all package SCSS files twice for the ES5 output (rel: angular#7403)
googlebot
added
the
cla: yes
|
My timings (as per gulp) with
|
|
I also did some testing where I compared |
| // These imports lack of type definitions. | ||
| const gulpSass = require('gulp-sass'); | ||
| const gulpIf = require('gulp-if'); | ||
| const gulpCleanCss = require('gulp-clean-css'); |
There was a problem hiding this comment.
Looks like there are types for gulp-sass and gulp-if.
There was a problem hiding this comment.
There definitely is, but for such small things we didn't even consider installing the types
(no real benefit; just blows the package)
There was a problem hiding this comment.
That's not what the comment says though.
There was a problem hiding this comment.
Well, since we didn't install the types, the imports basically lack of type definitions. Not the packages.
I see that the comment could be ambiguous, and I can change them in a follow-up that also considers all other similar comments like that. The comment was not really part of the PR.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
dart-sasstonode-sassdue to a pretty huge slow-down we noticed (can be revisited)packageoutput just in favor of the demo-app (slows down unnecessarily). This now allows us to live-reload theme changes within a second.