Skip to content

build(): fix source maps #7403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

build(): fix source maps #7403

merged 1 commit into from
Oct 3, 2017

Conversation

kara
Copy link
Contributor

@kara kara commented Sep 29, 2017 •
edited
Loading

Our source maps currently have incorrect mappings, which makes it difficult to debug in the browser and also skews results from code size analyzers like source-map-explorer.

This PR fixes our source maps by aligning the Material process to the angular/angular build process. This means:

  • Instead of downleveling to ES2015, creating a Rollup bundle, then transpiling that bundle down to ES5, we now downlevel to both ES2015 and ES5, then create separate Rollup bundles for each.
  • We are removing sorcery until we can upgrade tsickle and ngc to latest. Our versions of these break when mapping all the way back to TS. (temporary)
  • We have to add separate tsconfigs for transpiling to ES5 because our version of ngc doesn't allow overrides. When we update to compiler-cli 5.x, we should be able to remove these files. (temporary)

This PR also does some housekeeping:

  • Renames public_api files to public-api
  • Moves module code in cdk out into -module.ts files

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2017
@kara kara added the in progress This issue is currently in progress label Sep 29, 2017
@kara kara force-pushed the fix-sourcemaps branch 9 times, most recently from 260e95d to 628169d Compare September 30, 2017 02:08
@kara kara added pr: needs review and removed in progress This issue is currently in progress labels Sep 30, 2017
jelbourn
jelbourn reviewed Oct 2, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add explanation somewhere about why we do it this way?

@devversion
Copy link
Member

@jelbourn Why do we switch to public-api? I think it would be better to stay consistent with the Angular repository, because once we switch to Bazel we would have a similar setup.

@kara
Copy link
Contributor Author

kara commented Oct 2, 2017

@jelbourn LGTM-ed on slack since he is traveling

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 2, 2017
@kara kara merged commit f3b0b54 into angular:master Oct 3, 2017
This was referenced Oct 5, 2017
Merged
Closed
devversion added a commit to devversion/material2 that referenced this pull request Jul 29, 2018
@devversion
build: speed-up stylesheet building
3568794 
* Switches back from `dart-sass` to `node-sass` due to a pretty huge slow-down we noticed (can be revisited)
* No longer copies all SCSS files to the temporary `package` output just in favor of the demo-app (slows down unnecessarily). This now allows us to live-reload theme changes within a second.
* No longer rebuilds all package SCSS files twice for the ES5 output (rel: angular#7403)
devversion added a commit to devversion/material2 that referenced this pull request Jul 29, 2018
@devversion
build: speed-up stylesheet building
aa3b350 
* Switches back from `dart-sass` to `node-sass` due to a pretty huge slow-down we noticed (can be revisited)
* No longer copies all SCSS files to the temporary `package` output just in favor of the demo-app (slows down unnecessarily). This now allows us to live-reload theme changes within a second.
* No longer rebuilds all package SCSS files twice for the ES5 output (rel: angular#7403)
@devversion devversion mentioned this pull request Jul 29, 2018
Merged
jelbourn pushed a commit that referenced this pull request Jul 31, 2018
@devversion @jelbourn
build: speed-up stylesheet building (#12426)
e4ac04d 
* Switches back from `dart-sass` to `node-sass` due to a pretty huge slow-down we noticed (can be revisited)
* No longer copies all SCSS files to the temporary `package` output just in favor of the demo-app (slows down unnecessarily). This now allows us to live-reload theme changes within a second.
* No longer rebuilds all package SCSS files twice for the ES5 output (rel: #7403)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn left review comments

@amcdnl amcdnl Awaiting requested review from amcdnl

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

@josephperrott josephperrott Awaiting requested review from josephperrott

@mmalerba mmalerba Awaiting requested review from mmalerba

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kara @devversion @jelbourn @googlebot