Skip to content

feat(ng-add): set up gestures in CLI projects #12734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

devversion
Copy link
Member

  • Introduces a new option for the ng-add schematic that enables automatic set up of HammerJS in the CLI project. By default, gestures will be set up if someone runs ng add @angular/material.

@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Aug 19, 2018
@devversion devversion requested a review from amcdnl as a code owner August 19, 2018 10:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 19, 2018
@@ -13,6 +13,11 @@
"enum": ["indigo-pink", "deeppurple-amber", "pink-bluegrey", "purple-green", "custom"],
"default": "indigo-pink",
"description": "The theme to apply"
},
"gestures": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document this in schematics.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it to the bullet-points. Note that the schematics.md file is kind of outdated (misses the tree schematic etc.).

I want to improve that guide soon and also mention the different options for disabling gestures, creating a custom theme and more -- So there will be a follow-up.

@ngbot
Copy link

ngbot bot commented Aug 20, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@devversion devversion force-pushed the feat/ng-add-gesture-support branch from 438e802 to 3d7e731 Compare August 21, 2018 09:20
@ngbot
Copy link

ngbot bot commented Aug 21, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

* Introduces a new option for the `ng-add` schematic that enables automatic set up of HammerJS in the CLI project. By default, gestures will be set up if someone runs `ng add @angular/material`.
@devversion devversion force-pushed the feat/ng-add-gesture-support branch from 3d7e731 to abba4ee Compare August 22, 2018 15:16
@devversion
Copy link
Member Author

@jelbourn Rebased.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 22, 2018
@jelbourn jelbourn merged commit b919a48 into angular:master Aug 22, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants