-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(ng-add): set up gestures in CLI projects #12734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ng-add): set up gestures in CLI projects #12734
Conversation
@@ -13,6 +13,11 @@ | |||
"enum": ["indigo-pink", "deeppurple-amber", "pink-bluegrey", "purple-green", "custom"], | |||
"default": "indigo-pink", | |||
"description": "The theme to apply" | |||
}, | |||
"gestures": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document this in schematics.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it to the bullet-points. Note that the schematics.md
file is kind of outdated (misses the tree schematic etc.).
I want to improve that guide soon and also mention the different options for disabling gestures, creating a custom theme and more -- So there will be a follow-up.
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
438e802
to
3d7e731
Compare
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
* Introduces a new option for the `ng-add` schematic that enables automatic set up of HammerJS in the CLI project. By default, gestures will be set up if someone runs `ng add @angular/material`.
3d7e731
to
abba4ee
Compare
@jelbourn Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ng-add
schematic that enables automatic set up of HammerJS in the CLI project. By default, gestures will be set up if someone runsng add @angular/material
.