-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(ng-add): set up gestures in CLI projects #12734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jelbourn
merged 2 commits into
angular:master
from
devversion:feat/ng-add-gesture-support
Aug 22, 2018
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {Rule, Tree} from '@angular-devkit/schematics'; | ||
import {getWorkspace} from '@schematics/angular/utility/config'; | ||
import {getProjectFromWorkspace} from '../../utils/get-project'; | ||
import {Schema} from '../schema'; | ||
import {getProjectMainFile} from './project-main-file'; | ||
|
||
const hammerjsImportStatement = `import 'hammerjs';`; | ||
|
||
/** Adds HammerJS to the main file of the specified Angular CLI project. */ | ||
export function addHammerJsToMain(options: Schema): Rule { | ||
return (host: Tree) => { | ||
const workspace = getWorkspace(host); | ||
const project = getProjectFromWorkspace(workspace, options.project); | ||
const mainFile = getProjectMainFile(project); | ||
|
||
const recorder = host.beginUpdate(mainFile); | ||
const buffer = host.read(mainFile); | ||
|
||
if (!buffer) { | ||
return console.error(`Could not read the project main file (${mainFile}). Please manually ` + | ||
`import HammerJS in your main TypeScript file.`); | ||
} | ||
|
||
const fileContent = buffer.toString('utf8'); | ||
|
||
if (fileContent.includes(hammerjsImportStatement)) { | ||
return console.log(`HammerJS is already imported in the project main file (${mainFile}).`); | ||
} | ||
|
||
recorder.insertRight(0, `${hammerjsImportStatement}\n`); | ||
host.commitUpdate(recorder); | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {SchematicsException} from '@angular-devkit/schematics'; | ||
import {WorkspaceProject} from '@schematics/angular/utility/config'; | ||
|
||
/** Looks for the main TypeScript file in the given project and returns its path. */ | ||
export function getProjectMainFile(project: WorkspaceProject): string { | ||
const buildTarget = project.architect.build.options; | ||
|
||
if (buildTarget.main) { | ||
return buildTarget.main; | ||
} | ||
|
||
throw new SchematicsException( | ||
'Could not find the project main file inside of the workspace config.'); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document this in
schematics.md
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it to the bullet-points. Note that the
schematics.md
file is kind of outdated (misses the tree schematic etc.).I want to improve that guide soon and also mention the different options for disabling gestures, creating a custom theme and more -- So there will be a follow-up.