feat(ng-add): add preview URLs for theme choices #13723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Oct 21, 2018
| "x-prompt": "Set up HammerJS for gesture recognition?" | ||
| }, | ||
| "animations": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Whether Angular browser animations should be set up or not.", | ||
| "description": "Whether Angular browser animations should be set up.", |
There was a problem hiding this comment.
Can you update the according messages in schema.ts?
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121 Fixes angular#13708.
crisbeto
force-pushed
the
13708/ng-add-preview
branch
from
071aea2 to
81c0de0
Compare
crisbeto
added
the
blocked
crisbeto
removed
the
blocked
|
Not blocked anymore. |
mmalerba
pushed a commit
that referenced
this pull request
Oct 26, 2018
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121 Fixes #13708. **A couple of notes:** * Blocked until angular/material.angular.io#549 is merged and released. * Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121 Fixes angular#13708. **A couple of notes:** * Blocked until angular/material.angular.io#549 is merged and released. * Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts.
Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121
Fixes #13708.
A couple of notes:
patch, even though it's afeat, since it's basically just message changes.