This repository was archived by the owner on Dec 18, 2024. It is now read-only.
feat: add the ability to link to the site with a particular theme #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reworks the theming setup to store only the current theme's name, rather than the entire object in `localStorage`. This is more robust for the cases where we want to change the theme object's interface. * Adds the ability to link people to the docs site with a particular theme (e.g. https://material.angular.io?theme=purple-green). This allows us to preview the theme. For example we can use it for angular/components#13708 to show people what the theme would look like when they're prompted in a schematic.
devversion
approved these changes
Oct 21, 2018
mmalerba
pushed a commit
to angular/components
that referenced
this pull request
Oct 25, 2018
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121 Fixes #13708. **A couple of notes:** * Blocked until angular/material.angular.io#549 is merged and released. * Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
mmalerba
pushed a commit
to angular/components
that referenced
this pull request
Oct 26, 2018
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121 Fixes #13708. **A couple of notes:** * Blocked until angular/material.angular.io#549 is merged and released. * Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts. Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121 Fixes angular#13708. **A couple of notes:** * Blocked until angular/material.angular.io#549 is merged and released. * Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localStorage. This is more robust for the cases where we want to change the theme object's interface.