build: switch to docs-content from examples package #14612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository: * Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes. * Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
googlebot
added
the
cla: yes
devversion
added
target: patch
4 tasks
jelbourn
reviewed
Jan 9, 2019
| <pre class="docs-markdown-pre"> | ||
| <code class="docs-markdown-code"> | ||
| {%- highlight "typescript" -%} | ||
| const {$ constant.name | safe $}: {$ constant.type | safe $}; | ||
| {%- end_highlight -%} | ||
| </code> | ||
| </pre> | ||
| </div> |
There was a problem hiding this comment.
The indentation seems amiss here (and below)
There was a problem hiding this comment.
That's actually by intention because if we indent the <div> here, the pre and code element would have some additional whitespace and throw off the docs.
I tried using a HTML minifier for Bazel and tested it, but the whitespaces were preserved. That's why the pre and code already were indented in that way (we use a minifier at the moment;)
andrewseguin
pushed a commit
that referenced
this pull request
Jan 11, 2019
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository: * Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes. * Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository: * Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes. * Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With angular/material.angular.io#565 the docs-content will be pulled from the
@angular/material-examplespackage. Changes needed on this repository:examplesPathproperty member because we now compute thedocs-content/asset paths in a consistent way and don't want to mix up the source locations.