Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Use docs-content from NPM package #565

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

devversion
Copy link
Member

Blocked on updating the publish job on Material, so that it only publishes the NPM package.

@devversion devversion self-assigned this Dec 22, 2018
devversion added a commit to devversion/material2 that referenced this pull request Dec 22, 2018
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository:

* Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes.
* Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
andrewseguin pushed a commit to angular/components that referenced this pull request Jan 11, 2019
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository:

* Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes.
* Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
andrewseguin pushed a commit to angular/components that referenced this pull request Jan 11, 2019
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository:

* Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes.
* Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
With angular/material.angular.io#565 the docs-content will be pulled from the `@angular/material-examples` package. Changes needed on this repository:

* Since we update some styles and logic in favor of simplicity, we need to update the Dgeni templates to conform with these changes.
* Remove the unnecessary `examplesPath` property member because we now compute the `docs-content/` asset paths in a consistent way and don't want to mix up the source locations.
@devversion devversion force-pushed the use-docs-content-from-npm-package branch from 5410b1b to c31e536 Compare January 16, 2019 20:55
@devversion devversion force-pushed the use-docs-content-from-npm-package branch from c31e536 to 615f2fa Compare January 16, 2019 21:01
@devversion devversion assigned jelbourn and unassigned devversion Jan 16, 2019
@devversion
Copy link
Member Author

@jelbourn This one is ready for review. The changes in material2 have been merge, so that one is last remaining PR related to that.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit c920a38 into master Jan 18, 2019
@devversion devversion deleted the use-docs-content-from-npm-package branch January 21, 2019 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants